Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgadmin4][Patch]: Fixed minor issue in auto discover server whenentry is blank in the config file

[pgadmin4][Patch]: Fixed minor issue in auto discover server whenentry is blank in the config file

From
Akshay Joshi
Date:
Hi Hackers,

I have found one minor issue in auto discovery logic. getint function of ConfigParser throws exception if the value of the parameter is blank in the config file. Example: Port= 

Because of that exception pgAdmin4 unable to discover all the valid servers. Attached is the patch to fix that. Please review it. 

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server whenentry is blank in the config file

From
Dave Page
Date:
Thanks, applied.

On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

I have found one minor issue in auto discovery logic. getint function of ConfigParser throws exception if the value of the parameter is blank in the config file. Example: Port= 

Because of that exception pgAdmin4 unable to discover all the valid servers. Attached is the patch to fix that. Please review it. 

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company