Thread: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application servercould not be contacted

Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server could not be contacted

The issue is with french translation which has been taken care in the attached patch.

Thanks,
Khushboo
Attachment
Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server could not be contacted

The issue is with french translation which has been taken care in the attached patch.

We've seen similar issues with translations before. How can we write a test (or tests) to validate them?

One idea that springs to mind is to generate a new template against the app, then iterate through all the translation catalogs and attempt to translate each string that we find in the template we generated.

Alternatively, just iterate the catalogs, and grab each of the source strings from them and attempt to translate using the same catalog.

The former method would ensure that the current state of the application can be translated, but that of course might miss some strings in the catalogs. The latter would validate each catalog against itself, but might miss some strings that are in the application but haven't been merged yet (though, that doesn't seem like it would cause a problem).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server could not be contacted

The issue is with french translation which has been taken care in the attached patch.

We've seen similar issues with translations before. How can we write a test (or tests) to validate them?

One idea that springs to mind is to generate a new template against the app, then iterate through all the translation catalogs and attempt to translate each string that we find in the template we generated.

We can also use our messages.pot file as a template and attempt to translate each string that we find in it against all the translation catalogs. 
Alternatively, just iterate the catalogs, and grab each of the source strings from them and attempt to translate using the same catalog.

The former method would ensure that the current state of the application can be translated, but that of course might miss some strings in the catalogs. The latter would validate each catalog against itself, but might miss some strings that are in the application but haven't been merged yet (though, that doesn't seem like it would cause a problem).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server could not be contacted

The issue is with french translation which has been taken care in the attached patch.

We've seen similar issues with translations before. How can we write a test (or tests) to validate them?

One idea that springs to mind is to generate a new template against the app, then iterate through all the translation catalogs and attempt to translate each string that we find in the template we generated.

We can also use our messages.pot file as a template and attempt to translate each string that we find in it against all the translation catalogs. 

I suggested generating a new template for the test as we only occasionally update messages.pot (typically prior to releases), so it may be out of date.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 14, 2018 at 3:48 PM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server could not be contacted

The issue is with french translation which has been taken care in the attached patch.

We've seen similar issues with translations before. How can we write a test (or tests) to validate them?

One idea that springs to mind is to generate a new template against the app, then iterate through all the translation catalogs and attempt to translate each string that we find in the template we generated.

We can also use our messages.pot file as a template and attempt to translate each string that we find in it against all the translation catalogs. 

I suggested generating a new template for the test as we only occasionally update messages.pot (typically prior to releases), so it may be out of date.

Okay, we can implement this way. 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company