Thread: BUG #15167: error C2365: 'errcode' : redefi nition;previous definition

The following bug has been logged on the website:

Bug reference:      15167
Logged by:          Hao LI
Email address:      mixtrue@gmail.com
PostgreSQL version: 10.3
Operating system:   windows 7
Description:

Platform: windows 7 and vs 2008 

The source code checkout from : https://github.com/postgres/postgres.git.
and the git log as following:
commit 9cad926eb876a30d58a5b39789098da83a6ef91c

I run the command from src\tools\msvc\build.pl DEBUG, and get error as
following: 

d:\work\postgres\src\include\utils/elog.h(131): error C2365: 'errcode' :
redefinition; previous definition was 'typedef'.

Best Regards, 

Hao.

On 23/04/18 02:49, Hao Lee wrote:
> The more info:
> 1>d:\postgres\src\include\utils/elog.h(131) : error C2365: 'errcode' :
> redefinition; previous definition was 'typedef'
> 1>        C:\Program Files (x86)\Microsoft Visual Studio
> 9.0\VC\include\crtdefs.h(560) : see declaration of 'errcode'

In src/include/port/win32.h, we have this:

> /*
>  * We need to prevent <crtdefs.h> from defining a symbol conflicting with
>  * our errcode() function.  Since it's likely to get included by standard
>  * system headers, pre-emptively include it now.
>  */
> #if _MSC_VER >= 1400 || defined(HAVE_CRTDEFS_H)
> #define errcode __msvc_errcode
> #include <crtdefs.h>
> #undef errcode
> #endif

For some reason, that doesn't seem to be working as intended, on your 
system. Do you see the above in src/include/pg_config_os.h ?

What version of Visual Studio or Platform SDK are you using? What is the 
value of _MSC_VER on your system?

- Heikki