Thread: pgbench doc typos
Attached patch fixes two very minor typos in pgbench recently added documentations: - one about the mod() function - two about the hash() function -- Fabien.
Attachment
I did a quick review of this. The patch is just a doc typo fix and it applies cleanly to master (as of this email). I was able to build the docs, andthey look ok. Fixing the abs/hash bracketing seems clear. The wasn't sure about rewriting "mod(i, bj)" as "mod(i, j)", because there couldbe some convention about parameter names, but I can't think of anything the "b" could be in the case of mod. Edmund
Hello Edmund, Thanks for the check. You might consider turning the patch as ready in the cf app. > Fixing the abs/hash bracketing seems clear. The wasn't sure about > rewriting "mod(i, bj)" as "mod(i, j)", because there could be some > convention about parameter names, but I can't think of anything the "b" > could be in the case of mod. Might be a left-over a previous version which might have used MOD(a, b), but a/b are rather used for fp numbers and i/j for integers. -- Fabien.
On 30 March 2018 at 19:26, Fabien COELHO <coelho@cri.ensmp.fr> wrote: > Thanks for the check. You might consider turning the patch as ready in the > cf app. Ok, I have done so, since the patch is small and simple. >> Fixing the abs/hash bracketing seems clear. The wasn't sure about >> rewriting "mod(i, bj)" as "mod(i, j)", because there could be some >> convention about parameter names, but I can't think of anything the "b" >> could be in the case of mod. > > > Might be a left-over a previous version which might have used MOD(a, b), but > a/b are rather used for fp numbers and i/j for integers. Ah that seems possible.
On 3/30/18 03:30, Edmund Horner wrote: > On 30 March 2018 at 19:26, Fabien COELHO <coelho@cri.ensmp.fr> wrote: >> Thanks for the check. You might consider turning the patch as ready in the >> cf app. > > Ok, I have done so, since the patch is small and simple. > >>> Fixing the abs/hash bracketing seems clear. The wasn't sure about >>> rewriting "mod(i, bj)" as "mod(i, j)", because there could be some >>> convention about parameter names, but I can't think of anything the "b" >>> could be in the case of mod. >> >> >> Might be a left-over a previous version which might have used MOD(a, b), but >> a/b are rather used for fp numbers and i/j for integers. > > Ah that seems possible. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services