Thread: pgsql: Add long options to pg_resetwal and pg_controldata

pgsql: Add long options to pg_resetwal and pg_controldata

From
Peter Eisentraut
Date:
Add long options to pg_resetwal and pg_controldata

We were running out of good single-letter options for some upcoming
pg_resetwal functionality, so add long options to create more
possibilities.  Add to pg_controldata as well for symmetry.

based on patch by Bossart, Nathan <bossartn@amazon.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e22b27f0cb3ee03ee300d431997f5944ccf2d7b3

Modified Files
--------------
doc/src/sgml/ref/pg_controldata.sgml    |  8 +++++-
doc/src/sgml/ref/pg_resetwal.sgml       | 43 ++++++++++++++++++++++++---------
src/bin/pg_controldata/pg_controldata.c | 13 +++++++---
src/bin/pg_resetwal/pg_resetwal.c       | 43 ++++++++++++++++++++++-----------
4 files changed, 77 insertions(+), 30 deletions(-)


Re: pgsql: Add long options to pg_resetwal and pg_controldata

From
Andres Freund
Date:
On 2018-03-25 01:53:06 +0000, Peter Eisentraut wrote:
> Add long options to pg_resetwal and pg_controldata
> 
> We were running out of good single-letter options for some upcoming
> pg_resetwal functionality, so add long options to create more
> possibilities.  Add to pg_controldata as well for symmetry.
> 
> based on patch by Bossart, Nathan <bossartn@amazon.com>

Windows doesn't like this, I suspect you need to include getopt_long.h

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2018-03-25%2002%3A42%3A26

- Andres


Re: pgsql: Add long options to pg_resetwal and pg_controldata

From
Tom Lane
Date:
Andres Freund <andres@anarazel.de> writes:
> Windows doesn't like this, I suspect you need to include getopt_long.h

Not just Windows.  I went ahead and pushed this so I could resume
testing on gaur/pademelon.

            regards, tom lane