Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][RM#3195] Include service name when executing Backup,Restore etc tools

[pgAdmin4][RM#3195] Include service name when executing Backup,Restore etc tools

From
Murtuza Zabuawala
Date:
Hi,

PFA patch which will allow tools to pickup Service name properly.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][RM#3195] Include service name when executing Backup,Restore etc tools

From
Victoria Henry
Date:
Hey Murtuza,

This patch passed our test pipelines and it looks good.
Do we have any tests around this behavior?

Joao and Victoria

Re: [pgAdmin4][RM#3195] Include service name when executing Backup,Restore etc tools

From
Murtuza Zabuawala
Date:
Thanks Joao and Victoria for reviewing.

As Khushboo mentioned in her previous email we already have RM for the same(https://redmine.postgresql.org/issues/3206), We will send separate patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 16, 2018 at 2:25 AM, Victoria Henry <vhenry@pivotal.io> wrote:
Hey Murtuza,

This patch passed our test pipelines and it looks good.
Do we have any tests around this behavior?

Joao and Victoria

Re: [pgAdmin4][RM#3195] Include service name when executing Backup,Restore etc tools

From
Dave Page
Date:
Thanks, applied.

On Thu, Mar 15, 2018 at 4:15 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch which will allow tools to pickup Service name properly.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company