Thread: pgAdmin 4 commit: Fix unicode handling in the external process toolsan
Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes#3157. Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a88e1 Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com> Modified Files -------------- web/pgadmin/misc/bgprocess/processes.py | 36 +++++++++++++++++++++-- web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++-- web/pgadmin/tools/backup/__init__.py | 5 ++-- 3 files changed, 38 insertions(+), 9 deletions(-)
Re: pgAdmin 4 commit: Fix unicode handling in the external processtools an
From
Joao De Almeida Pereira
Date:
Hi Dave, Khushboo
Looks like there is a linting issue with this commit:
Successfully installed pycodestyle-2.3.1/tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace around operator./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2)1 E225 missing whitespace around operator1 E303 too many blank lines (2)2
Best Regards,
Victoria & Joao
On Tue, Mar 13, 2018 at 4:45 PM Dave Page <dpage@pgadmin.org> wrote:
Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes #3157.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a88e1
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 36 +++++++++++++++++++++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
web/pgadmin/tools/backup/__init__.py | 5 ++--
3 files changed, 38 insertions(+), 9 deletions(-)
Thanks - fixed. That begs the question of why Jenkins didn't catch it though :-/
On Tue, Mar 13, 2018 at 4:54 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave, KhushbooLooks like there is a linting issue with this commit:Successfully installed pycodestyle-2.3.1/tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2 ./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace around operator ./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2) 1 E225 missing whitespace around operator1 E303 too many blank lines (2)2Best Regards,Victoria & JoaoOn Tue, Mar 13, 2018 at 4:45 PM Dave Page <dpage@pgadmin.org> wrote:Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes #3157.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a= commitdiff;h= 802269910c37a52aa57479bbcc1d8d 078f6a88e1
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 36 +++++++++++++++++++++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
web/pgadmin/tools/backup/__init__.py | 5 ++--
3 files changed, 38 insertions(+), 9 deletions(-)
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company