Postgres Pro
Downloads
Home   >   mailing lists

Thread: pgAdmin 4 commit: Refactor server dialogue validation for better unitt

pgAdmin 4 commit: Refactor server dialogue validation for better unitt

From
Dave Page
Date:
Refactor server dialogue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json                                   |   3 +-
.../server_groups/servers/static/js/server.js      | 113 ++-------------------
web/pgadmin/static/bundle/browser.js               |   2 +-
web/pgadmin/static/js/browser/index.js             |  10 ++
.../static/js/browser/server_groups/index.js       |  10 ++
.../server_groups/servers/databases/index.js       |  10 ++
.../js/browser/server_groups/servers/index.js      |  11 ++
.../server_groups/servers/model_validation.js      | 104 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++
web/yarn.lock                                      |  46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)

Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t

From
Khushboo Vashi
Date:
Hi Joao/Victoria,

I am getting an error while editing the server properties. Please refer the attached screen-shot for the same.

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <dpage@pgadmin.org> wrote:
Refactor server dialogue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json                                   |   3 +-
.../server_groups/servers/static/js/server.js      | 113 ++-------------------
web/pgadmin/static/bundle/browser.js               |   2 +-
web/pgadmin/static/js/browser/index.js             |  10 ++
.../static/js/browser/server_groups/index.js       |  10 ++
.../server_groups/servers/databases/index.js       |  10 ++
.../js/browser/server_groups/servers/index.js      |  11 ++
.../server_groups/servers/model_validation.js      | 104 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++
web/yarn.lock                                      |  46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)


Attachment

Re: pgAdmin 4 commit: Refactor server dialogue validation for betterunit t

From
Joao De Almeida Pereira
Date:
Hi Khushboo,
Good catch, attached you can find the fix for the problem.

Thanks
Victoria & Joao

On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao/Victoria,

I am getting an error while editing the server properties. Please refer the attached screen-shot for the same.

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <dpage@pgadmin.org> wrote:
Refactor server dialogue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json                                   |   3 +-
.../server_groups/servers/static/js/server.js      | 113 ++-------------------
web/pgadmin/static/bundle/browser.js               |   2 +-
web/pgadmin/static/js/browser/index.js             |  10 ++
.../static/js/browser/server_groups/index.js       |  10 ++
.../server_groups/servers/databases/index.js       |  10 ++
.../js/browser/server_groups/servers/index.js      |  11 ++
.../server_groups/servers/model_validation.js      | 104 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++
web/yarn.lock                                      |  46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)


Attachment

Re: pgAdmin 4 commit: Refactor server dialogue validation for betterunit t

From
Dave Page
Date:
Thanks, applied.

On Wed, Mar 14, 2018 at 12:10 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,
Good catch, attached you can find the fix for the problem.

Thanks
Victoria & Joao

On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao/Victoria,

I am getting an error while editing the server properties. Please refer the attached screen-shot for the same.

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <dpage@pgadmin.org> wrote:
Refactor server dialogue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json                                   |   3 +-
.../server_groups/servers/static/js/server.js      | 113 ++-------------------
web/pgadmin/static/bundle/browser.js               |   2 +-
web/pgadmin/static/js/browser/index.js             |  10 ++
.../static/js/browser/server_groups/index.js       |  10 ++
.../server_groups/servers/databases/index.js       |  10 ++
.../js/browser/server_groups/servers/index.js      |  11 ++
.../server_groups/servers/model_validation.js      | 104 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++
web/yarn.lock                                      |  46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company