Thread: Re: pgsql: Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

Thomas Munro wrote:
> On Tue, Mar 6, 2018 at 11:39 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
> 
> Is this commit responsible for this valgrind error?
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-03-05%2023%3A03%3A01
> 
> ==430== Invalid read of size 2
> ==430==    at 0x4C33F6F: memcpy@GLIBC_2.2.5 (vg_replace_strmem.c:1021)
> ==430==    by 0x483419: heap_fill_tuple (heaptuple.c:276)
> ==430==    by 0x4842C6: heap_form_tuple (heaptuple.c:771)
> ==430==    by 0x6474B5: CreateStatistics (statscmds.c:322)
> ==430==    by 0x865784: ProcessUtilitySlow (utility.c:1668)

Uh ... it probably is.  I'll take a look tomorrow, but my guess is that
my last minute removal of the conversion to Name is to blame.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Alvaro Herrera wrote:
> Thomas Munro wrote:
> > On Tue, Mar 6, 2018 at 11:39 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > > Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
> > 
> > Is this commit responsible for this valgrind error?
> > 
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-03-05%2023%3A03%3A01

> Uh ... it probably is.  I'll take a look tomorrow, but my guess is that
> my last minute removal of the conversion to Name is to blame.

I was right about the cause.  Fix pushed.  Thanks for notifying.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services