Thread: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotationmarks to column names for the "add index" functions
[pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotationmarks to column names for the "add index" functions
From
Khushboo Vashi
Date:
Hi,
Please find the attached patch to fix RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions
Thanks,
Khushboo
Attachment
Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotationmarks to column names for the "add index" functions
From
Dave Page
Date:
Hi
--
On Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions
This causes additional quoting on regular tables. Please see the generated SQL for the index below:
-- Table: public."CamelCase"
-- DROP TABLE public."CamelCase";
CREATE TABLE public."CamelCase"
(
"ID" bigint NOT NULL DEFAULT nextval('"CamelCase_ID_seq"'::regclass),
"SomeColumn" text COLLATE pg_catalog."default",
b boolean,
CONSTRAINT "CamelCase_pkey" PRIMARY KEY ("ID")
)
WITH (
OIDS = FALSE
)
TABLESPACE pg_default;
ALTER TABLE public."CamelCase"
OWNER to postgres;
-- Index: MixedCase_IDX
-- DROP INDEX public."MixedCase_IDX";
CREATE INDEX "MixedCase_IDX"
ON public."CamelCase" USING btree
("""ID""")
TABLESPACE pg_default;
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotationmarks to column names for the "add index" functions
From
Khushboo Vashi
Date:
On Mon, Feb 19, 2018 at 5:19 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functionsThis causes additional quoting on regular tables. Please see the generated SQL for the index below:
Please find the attached updated patch.
-- Table: public."CamelCase"-- DROP TABLE public."CamelCase";CREATE TABLE public."CamelCase"("ID" bigint NOT NULL DEFAULT nextval('"CamelCase_ID_seq"'::regclass), "SomeColumn" text COLLATE pg_catalog."default",b boolean,CONSTRAINT "CamelCase_pkey" PRIMARY KEY ("ID"))WITH (OIDS = FALSE)TABLESPACE pg_default;ALTER TABLE public."CamelCase"OWNER to postgres;-- Index: MixedCase_IDX-- DROP INDEX public."MixedCase_IDX";CREATE INDEX "MixedCase_IDX"ON public."CamelCase" USING btree("""ID""")TABLESPACE pg_default;--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotationmarks to column names for the "add index" functions
From
Dave Page
Date:
Thanks, applied.
On Mon, Feb 19, 2018 at 1:27 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
On Mon, Feb 19, 2018 at 5:19 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functionsThis causes additional quoting on regular tables. Please see the generated SQL for the index below:Please find the attached updated patch.-- Table: public."CamelCase"-- DROP TABLE public."CamelCase";CREATE TABLE public."CamelCase"("ID" bigint NOT NULL DEFAULT nextval('"CamelCase_ID_seq"'::regclass), "SomeColumn" text COLLATE pg_catalog."default",b boolean,CONSTRAINT "CamelCase_pkey" PRIMARY KEY ("ID"))WITH (OIDS = FALSE)TABLESPACE pg_default;ALTER TABLE public."CamelCase"OWNER to postgres;-- Index: MixedCase_IDX-- DROP INDEX public."MixedCase_IDX";CREATE INDEX "MixedCase_IDX"ON public."CamelCase" USING btree("""ID""")TABLESPACE pg_default;--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company