Thread: Missing comment edit

Hello.

I happend to find that the comment on formdesc is missing
pg_subscription. Please find the attached patch (I'm sure:) to
fix that .

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index d5cc246..022a48c 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -1848,8 +1848,8 @@ LookupOpclassInfo(Oid operatorClassOid,
  *        catalogs.
  *
  * formrdesc is currently used for: pg_database, pg_authid, pg_auth_members,
- * pg_shseclabel, pg_class, pg_attribute, pg_proc, and pg_type
- * (see RelationCacheInitializePhase2/3).
+ * pg_shseclabel, pg_subscription, pg_class, pg_attribute, pg_proc, and
+ * pg_type (see RelationCacheInitializePhase2/3).
  *
  * Note that these catalogs can't have constraints (except attnotnull),
  * default values, rules, or triggers, since we don't cope with any of that.

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> I happend to find that the comment on formdesc is missing
> pg_subscription. Please find the attached patch (I'm sure:) to
> fix that .

Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
to just remove it, because it'll certainly be wrong again in future.
It's not telling you anything you can't find out with a trivial search
in the same file, so is it worth the maintenance overhead?

            regards, tom lane

On 2018-02-28 19:03:01 -0500, Tom Lane wrote:
> Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> > I happend to find that the comment on formdesc is missing
> > pg_subscription. Please find the attached patch (I'm sure:) to
> > fix that .
> 
> Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
> to just remove it, because it'll certainly be wrong again in future.
> It's not telling you anything you can't find out with a trivial search
> in the same file, so is it worth the maintenance overhead?

+1. Do you want to do the honors?  If you don't and nobody comments,
I'll do so.

- Andres

Andres Freund <andres@anarazel.de> writes:
> On 2018-02-28 19:03:01 -0500, Tom Lane wrote:
>> Hmm ... certainly, that comment is now wrong, but I'm kind of inclined
>> to just remove it, because it'll certainly be wrong again in future.
>> It's not telling you anything you can't find out with a trivial search
>> in the same file, so is it worth the maintenance overhead?

> +1. Do you want to do the honors?  If you don't and nobody comments,
> I'll do so.

Done.

            regards, tom lane