Thread: pgAdmin4: Patch for RM#3060
Hi Dave,
Please find the patch for function name quoting in SQL tab for functions.(RM#3060)
Files affected:
pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/default/get_definition.sql
I have added code for quoting string wherever needed.
Thanks Harshal for help!
Regards,
navnath
Attachment
Hi
--
On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,Please find the patch for function name quoting in SQL tab for functions.(RM#3060)Files affected:pgadmin/browser/server_groups/servers/databases/schemas/ functions/__init__.py pgadmin/browser/server_groups/servers/databases/schemas/ functions/templates/function/ pg/sql/default/get_definition. sql I have added code for quoting string wherever needed.Thanks Harshal for help!
Unfortunately this doesn't apply. Can you rebase it please?
Thanks!
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Feb 9, 2018 at 10:06 AM, Dave Page <dpage@pgadmin.org> wrote:
-- HiOn Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote: Hi Dave,Please find the patch for function name quoting in SQL tab for functions.(RM#3060)Files affected:pgadmin/browser/server_groups/servers/databases/schemas/func tions/__init__.py pgadmin/browser/server_groups/servers/databases/schemas/func tions/templates/function/pg/ sql/default/get_definition.sql I have added code for quoting string wherever needed.Thanks Harshal for help!Unfortunately this doesn't apply. Can you rebase it please?
Hold that - my tree wasn't clean...
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Thanks - patch applied!
On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,Please find the patch for function name quoting in SQL tab for functions.(RM#3060)Files affected:--pgadmin/browser/server_groups/servers/databases/schemas/ functions/__init__.py pgadmin/browser/server_groups/servers/databases/schemas/ functions/templates/function/ pg/sql/default/get_definition. sql I have added code for quoting string wherever needed.Thanks Harshal for help!Regards,navnath
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company