Thread: pg_upgrade tests failing on current master

Hi,

The current master HEAD fails pg_upgrade tests on my machine.

If I revert the "Move handling of database properties from pg_dumpall
into pg_dump." commit b3f8401205afdaf63cb20dc316d44644c933d5a1 the test
passes.

The error is:

pg_restore: creating RULE "public.rtest_emp rtest_emp_del"
pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 5168; 2618 34331 RULE
rtest_emp rtest_emp_del mnencia
pg_restore: [archiver (db)] could not execute query: ERROR:  invalid
input syntax for type money: "$0.00"
LINE 3: ... ("old"."ename", CURRENT_USER, 'fired'::"bpchar", '$0.00'::"...
                                                             ^
    Command was: CREATE RULE "rtest_emp_del" AS
    ON DELETE TO "rtest_emp" DO  INSERT INTO "rtest_emplog" ("ename",
"who", "action", "newsal", "oldsal")
  VALUES ("old"."ename", CURRENT_USER, 'fired'::"bpchar",
'$0.00'::"money", "old"."salary");

I'm on OSX with locale "it_IT.UTF-8"

If I set LANG=C the problem disappears.

Regards,
Marco

--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco.nenciarini@2ndQuadrant.it | www.2ndQuadrant.it

On Tue, Jan 23, 2018 at 12:21:51PM +0100, Marco Nenciarini wrote:
> into pg_dump." commit b3f8401205afdaf63cb20dc316d44644c933d5a1 the test
> passes.
>
> The error is:
>
> pg_restore: creating RULE "public.rtest_emp rtest_emp_del"
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 5168; 2618 34331 RULE
> rtest_emp rtest_emp_del mnencia
> pg_restore: [archiver (db)] could not execute query: ERROR:  invalid
> input syntax for type money: "$0.00"
> LINE 3: ... ("old"."ename", CURRENT_USER, 'fired'::"bpchar", '$0.00'::"...
>                                                              ^
>     Command was: CREATE RULE "rtest_emp_del" AS
>     ON DELETE TO "rtest_emp" DO  INSERT INTO "rtest_emplog" ("ename",
> "who", "action", "newsal", "oldsal")
>   VALUES ("old"."ename", CURRENT_USER, 'fired'::"bpchar",
> '$0.00'::"money", "old"."salary");
>
> I'm on OSX with locale "it_IT.UTF-8"

A couple of Windows buildfarm machines are complaining as well, like
whelk:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2018-01-22%2022%3A41%3A06

pg_restore: [archiver (db)] Error while PROCESSING TOC:
pg_restore: [archiver (db)] Error from TOC entry 4871; 2618 34331 RULE rtest_emp rtest_emp_del pgbf
pg_restore: [archiver (db)] could not execute query: ERROR:  invalid input syntax for type money: "$0.00"
LINE 3: ... ("old"."ename", CURRENT_USER, 'fired'::"bpchar", '$0.00'::"...
--
Michael

Marco Nenciarini <marco.nenciarini@2ndquadrant.it> writes:
> The current master HEAD fails pg_upgrade tests on my machine.

Yup, see <12453.1516655001@sss.pgh.pa.us>

            regards, tom lane