Thread: Minor code improvement to estimate_path_cost_size in postgres_fdw

Hi,

The declaration of estimate_path_cost_size uses baserel, but
the actual definition uses foreignrel. It would be better to sync.

Please find attached a patch.

Tatsuro Yamada
NTT Open Source Software Center

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> writes:
> The declaration of estimate_path_cost_size uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.

Yeah, the join_conds parameter's been renamed at some point too :-(
Fixed.

            regards, tom lane

On 2018/01/12 1:54, Tom Lane wrote:
> Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp> writes:
>> The declaration of estimate_path_cost_size uses baserel, but
>> the actual definition uses foreignrel. It would be better to sync.
> 
> Yeah, the join_conds parameter's been renamed at some point too :-(
> Fixed.
> 
>             regards, tom lane

Thanks! :)

Regards,
Tatsuro Yamada