Thread: pgsql: Clean up Perl code according to perlcritic
Clean up Perl code according to perlcritic Fix all perlcritic warnings of severity level 5, except in src/backend/utils/Gen_dummy_probes.pl, which is automatically generated. Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/facde2a98f0b5f7689b4e30a9e7376e926e733b8 Modified Files -------------- contrib/intarray/bench/create_test.pl | 20 +-- doc/src/sgml/generate-errcodes-table.pl | 2 +- doc/src/sgml/mk_feature_tables.pl | 12 +- src/backend/catalog/Catalog.pm | 8 +- src/backend/catalog/genbki.pl | 64 ++++----- src/backend/parser/check_keywords.pl | 30 ++--- src/backend/storage/lmgr/generate-lwlocknames.pl | 30 ++--- src/backend/utils/Gen_fmgrtab.pl | 32 ++--- src/backend/utils/generate-errcodes.pl | 2 +- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 26 ++-- src/bin/pg_ctl/t/001_start_stop.pl | 14 +- src/bin/psql/create_help.pl | 28 ++-- src/interfaces/ecpg/preproc/check_rules.pl | 12 +- src/interfaces/libpq/test/regress.pl | 14 +- src/pl/plperl/plc_perlboot.pl | 4 +- src/pl/plperl/plc_trusted.pl | 2 +- src/pl/plperl/text2macro.pl | 8 +- src/pl/plpgsql/src/generate-plerrcodes.pl | 2 +- src/pl/plpython/generate-spiexceptions.pl | 2 +- src/pl/tcl/generate-pltclerrcodes.pl | 2 +- src/test/locale/sort-test.pl | 6 +- src/test/perl/PostgresNode.pm | 8 +- src/test/perl/TestLib.pm | 16 +-- src/test/ssl/ServerSetup.pm | 48 +++---- src/tools/fix-old-flex-code.pl | 4 +- src/tools/msvc/Install.pm | 10 +- src/tools/msvc/Mkvcbuild.pm | 2 +- src/tools/msvc/Project.pm | 28 ++-- src/tools/msvc/Solution.pm | 162 +++++++++++------------ src/tools/msvc/build.pl | 8 +- src/tools/msvc/builddoc.pl | 2 +- src/tools/msvc/gendef.pl | 18 +-- src/tools/msvc/install.pl | 4 +- src/tools/msvc/mkvcbuild.pl | 4 +- src/tools/msvc/pgbison.pl | 4 +- src/tools/msvc/pgflex.pl | 12 +- src/tools/msvc/vcregress.pl | 19 +-- src/tools/pginclude/pgcheckdefines | 32 ++--- src/tools/pgindent/pgindent | 5 +- src/tools/version_stamp.pl | 6 +- src/tools/win32tzlist.pl | 6 +- 41 files changed, 360 insertions(+), 358 deletions(-)
On 03/27/2017 08:23 AM, Peter Eisentraut wrote: > Clean up Perl code according to perlcritic > > Fix all perlcritic warnings of severity level 5, except in > src/backend/utils/Gen_dummy_probes.pl, which is automatically generated. > > Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> > Reviewed-by: Daniel Gustafsson <daniel@yesql.se> This contains at least one non-cosmetic change and the MSVC buildfarm members have reacted accordingly: @opts = grep { - s/\Q$(top_builddir)\E/\"$topdir\"/; - $_ !~ /\$\(/ && $_ =~ /^--/ + my $x = $_; + $x =~ s/\Q$(top_builddir)\E/\"$topdir\"/; + $x !~ /\$\(/ && $x =~ /^--/ cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services