Thread: [pgAdmin4][Patch]: To fix the issue in File manager

[pgAdmin4][Patch]: To fix the issue in File manager

From
Murtuza Zabuawala
Date:
Hi,

PFA patch to fix referenced before assignment bug in file manager.
RM#2934

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][Patch]: To fix the issue in File manager

From
Dave Page
Date:
Hi

Thanks, applied. I noticed whilst testing that the Select button on the file dialogue can become enabled again following navigation to another directory. That then allows you to click it when no files are selected, which of course fails horribly.

Can you take a look at that please? https://redmine.postgresql.org/issues/2937

On Tue, Dec 5, 2017 at 10:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix referenced before assignment bug in file manager.
RM#2934

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To fix the issue in File manager

From
Murtuza Zabuawala
Date:
Hi Dave,

I'm not able to re-produce the issue, I've updated the RM with my steps, please check and let me know If I missed anything.

-- Murtuza

On Wed, Dec 6, 2017 at 10:17 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Thanks, applied. I noticed whilst testing that the Select button on the file dialogue can become enabled again following navigation to another directory. That then allows you to click it when no files are selected, which of course fails horribly.

Can you take a look at that please? https://redmine.postgresql.org/issues/2937

On Tue, Dec 5, 2017 at 10:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix referenced before assignment bug in file manager.
RM#2934

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company