Thread: bgwriter_lru_maxpages range in postgresql.conf
(My earlier post has been stuck in infinite moderation due to the use of a common 6 letter abbreviation for configuration, so I will try again without it)
With v10, commit 14ca9abfbe4643408a, the upper limit on bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but the postgresql.conf.sample was not updated.
#bgwriter_lru_maxpages = 100 # 0-1000 max buffers written/round
I don't see any precedence for including INT_MAX-type limits in the sample configuration file, so maybe something like this:?
#bgwriter_lru_maxpages = 100 # max buffers written/round, 0 to turn off
Cheers,
Jeff
On Thu, Nov 16, 2017 at 1:26 PM, Jeff Janes <jeff.janes@gmail.com> wrote: > (My earlier post has been stuck in infinite moderation due to the use of a > common 6 letter abbreviation for configuration, so I will try again without > it) > > With v10, commit 14ca9abfbe4643408a, the upper limit on > bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but the > postgresql.conf.sample was not updated. > > #bgwriter_lru_maxpages = 100 # 0-1000 max buffers written/round > > I don't see any precedence for including INT_MAX-type limits in the sample > configuration file, so maybe something like this:? > > #bgwriter_lru_maxpages = 100 # max buffers written/round, 0 to turn > off wfm. Patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Thu, Nov 16, 2017 at 11:10 AM, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Nov 16, 2017 at 1:26 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> (My earlier post has been stuck in infinite moderation due to the use of a
> common 6 letter abbreviation for configuration, so I will try again without
> it)
>
> With v10, commit 14ca9abfbe4643408a, the upper limit on
> bgwriter_lru_maxpages was changed from 1000 to INT_MAX / 2, but the
> postgresql.conf.sample was not updated.
>
> #bgwriter_lru_maxpages = 100 # 0-1000 max buffers written/round
>
> I don't see any precedence for including INT_MAX-type limits in the sample
> configuration file, so maybe something like this:?
>
> #bgwriter_lru_maxpages = 100 # max buffers written/round, 0 to turn
> off
wfm. Patch?
I changed it to "0 disables" to be more consistent with other locations.
Cheers,
Jeff
Attachment
On Thu, Nov 16, 2017 at 4:40 PM, Jeff Janes <jeff.janes@gmail.com> wrote: > I changed it to "0 disables" to be more consistent with other locations. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company