Postgres Pro
Downloads
Home   >   mailing lists

Thread: test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction

test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction

From
Ashutosh Sharma
Date:
Hi All,

The test_session_hooks--1.0.sql file in the newly added 'test_session_hooks' module suggests to load the extension named 'test_hook_session' instead of 'test_session_hooks'  and i think it needs to be corrected. Here are the contents available in test_session_hooks--1.0.sql file.

[ashu@localhost test_session_hooks]$ cat test_session_hooks--1.0.sql
/* src/test/modules/test_hook_session/test_hook_session--1.0.sql */

-- complain if script is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION test_hook_session" to load this file. \quit

Note : Please ignore this mail if it has already been reported by someone.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Re: test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction

From
Michael Paquier
Date:
On Thu, Nov 16, 2017 at 7:49 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> The test_session_hooks--1.0.sql file in the newly added 'test_session_hooks'
> module suggests to load the extension named 'test_hook_session' instead of
> 'test_session_hooks'  and i think it needs to be corrected. Here are the
> contents available in test_session_hooks--1.0.sql file.
>
>
> -- complain if script is sourced in psql, rather than via CREATE EXTENSION
> \echo Use "CREATE EXTENSION test_hook_session" to load this file. \quit

The sql file, the control file, and the definitions of DATA and
EXTENSION in the Makefile could just be deleted.
-- 
Michael

Re: test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction

From
Ashutosh Sharma
Date:
On Thu, Nov 16, 2017 at 6:47 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Thu, Nov 16, 2017 at 7:49 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> The test_session_hooks--1.0.sql file in the newly added 'test_session_hooks'
> module suggests to load the extension named 'test_hook_session' instead of
> 'test_session_hooks'  and i think it needs to be corrected. Here are the
> contents available in test_session_hooks--1.0.sql file.
>
>
> -- complain if script is sourced in psql, rather than via CREATE EXTENSION
> \echo Use "CREATE EXTENSION test_hook_session" to load this file. \quit

The sql file, the control file, and the definitions of DATA and
EXTENSION in the Makefile could just be deleted.

Oh Yes, I just saw your latest patch that you shared an hour before. You have removed the control file and test_hook_session--1.0.sql files. So, my complaint is no more valid. Thanks.
 
--
Michael