Thread: [pgAdmin4][Patch]: To make error message uniform for Create schema action

[pgAdmin4][Patch]: To make error message uniform for Create schema action

From
Murtuza Zabuawala
Date:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][Patch]: To make error message uniform for Createschema action

From
Dave Page
Date:


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: To make error message uniform for Createschema action

From
Murtuza Zabuawala
Date:
Hi,

PFA updated.

On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <dpage@pgadmin.org> wrote:


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.
​That's coming from ajax statusText, I thought it was intended.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][Patch]: To make error message uniform for Createschema action

From
Dave Page
Date:
Thanks, applied.

On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA updated.

On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <dpage@pgadmin.org> wrote:


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.
​That's coming from ajax statusText, I thought it was intended.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company