Thread: Typo in auth-scram.c
Hi all, auth-scram.c is visibly not able to do things in a deterministic way, that's more determinisitc: --- a/src/backend/libpq/auth-scram.c +++ b/src/backend/libpq/auth-scram.c @@ -1116,7 +1116,7 @@ build_server_final_message(scram_state *state) /* - * Determinisitcally generate salt for mock authentication, using a SHA256 + * Deterministically generate salt for mock authentication, using a SHA256 * hash based on the username and a cluster-level secret key. Returns a * pointer to a static buffer of size SCRAM_DEFAULT_SALT_LEN. */ Thanks, -- Michael
Attachment
Michael, * Michael Paquier (michael.paquier@gmail.com) wrote: > auth-scram.c is visibly not able to do things in a deterministic way, > that's more determinisitc: Hah, excellent point, will push in a moment (also to test that the -committers list is happy with the change to pglister :). Thanks! Stephen
On Mon, Nov 13, 2017 at 10:37 PM, Stephen Frost <sfrost@snowman.net> wrote: > * Michael Paquier (michael.paquier@gmail.com) wrote: >> auth-scram.c is visibly not able to do things in a deterministic way, >> that's more determinisitc: > > Hah, excellent point, will push in a moment (also to test that the > -committers list is happy with the change to pglister :). Thanks, Stephen. -- Michael