Home > mailing lists

Thread: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't usedefault values

[pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't usedefault values

From

Surinder Kumar

Date:

01 April 2017, 17:45:16

Issues fixed:

1. If a column is defined with a default modifier, there is now way to insert the row with those defaults.

The column will be left blank and it will take default value automatically.

2. If a column has a not-null constraint then an error is returned and the row is not inserted.

The column will be left blank

The default values for new added rows will be displayed on refresh/execute.

Please find attached patch and review.

Thanks

Surinder

Attachment

RM_2257.patch

Re: [pgAdmin4][Patch][RM2257]: Query tool - Insertrow doesn't use default values

From

Matthew Kleiman

Date:

04 April 2017, 22:37:34

Hi Surinder,

We looked at your fix for default values in the query tool editor.

We think the user experience could be further improved by seeing the actual default value instead of the empty cell.

As an intermediate step, there would be user value in seeing "[default]" instead of the blank cell (or what used to be "[null]").

Thanks,

George and Matt

On Sat, Apr 1, 2017 at 7:45 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

Issues fixed:

1. If a column is defined with a default modifier, there is now way to insert the row with those defaults.
The column will be left blank and it will take default value automatically.

2. If a column has a not-null constraint then an error is returned and the row is not inserted.
The column will be left blank

The default values for new added rows will be displayed on refresh/execute.

Please find attached patch and review.

Thanks
Surinder

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers