Thread: Re: [COMMITTERS] pgsql: Remove secondary checkpoint

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

From
Tom Lane
Date:
Andres Freund <andres@anarazel.de> writes:
> On 2017-11-07 17:57:31 +0000, Simon Riggs wrote:
>> Remove secondary checkpoint

> FWIW, I don't think this should be applied without a pg_resetxlog
> feature allowing to manually use older checkpoints.

Uh, what?  We have never before insisted on pg_resetxlog being able
to use WAL across a WAL format change, and there have been many of
those.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

From
Andres Freund
Date:
On 2017-11-07 14:12:19 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2017-11-07 17:57:31 +0000, Simon Riggs wrote:
> >> Remove secondary checkpoint
> 
> > FWIW, I don't think this should be applied without a pg_resetxlog
> > feature allowing to manually use older checkpoints.
> 
> Uh, what?  We have never before insisted on pg_resetxlog being able
> to use WAL across a WAL format change, and there have been many of
> those.

I think you misunderstand my point - I'm saying that pg_resetxlog should
be able to force the use of older checkpoints, basically as a fallback
to cases where the previous approach might actually have worked, not
that it needs to work across format changes.

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

From
Tom Lane
Date:
Andres Freund <andres@anarazel.de> writes:
> I think you misunderstand my point - I'm saying that pg_resetxlog should
> be able to force the use of older checkpoints, basically as a fallback
> to cases where the previous approach might actually have worked, not
> that it needs to work across format changes.

That seems like a completely separate feature --- and one of dubious
value, frankly.  The further back you go, the less likely it'd be
to work.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers