Thread: Isn't win32_make_absolute() a waste of time?

Isn't win32_make_absolute() a waste of time?

From
Tom Lane
Date:
AFAICS, src/port/exec.c's win32_make_absolute() is never called with
a relative path.  Is there a reason not to remove it (ie, does it do
something beyond what the comments claim)?

            regards, tom lane

Re: Isn't win32_make_absolute() a waste of

From
Andrew Dunstan
Date:
At the time this was included in initdb.c, if you called initdb like
this:  "bin/initdb" then the path to postgres ended up being determined
as "bin/postgres". This function was put in to get around a problem
Windows had in certain cases with such relative paths. That code path
has now changed so radically that you might be right in thinking it
redundant - I will have a closer look unless Bruce can give a
categorical answer.

cheers

andrew

Tom Lane wrote:

>AFAICS, src/port/exec.c's win32_make_absolute() is never called with
>a relative path.  Is there a reason not to remove it (ie, does it do
>something beyond what the comments claim)?
>
>
>
>