Thread: [HACKERS] [PATCH] Comment typo in get_collation_name() comment
[HACKERS] [PATCH] Comment typo in get_collation_name() comment
From
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Hi Hackers, The comment for get_collation_name() seems to have been copy-pasted from get_constraint_name(), but missed one s/constraint/collation/. Patch attached. -- "I use RMS as a guide in the same way that a boat captain would use a lighthouse. It's good to know where it is, but you generally don't want to find yourself in the same spot." - Tollef Fog Heen diff --git a/src/backend/utils/cache/lsyscache.c b/src/backend/utils/cache/lsyscache.c index 48961e31aa..acbd9ac63e 100644 --- a/src/backend/utils/cache/lsyscache.c +++ b/src/backend/utils/cache/lsyscache.c @@ -958,7 +958,7 @@ get_atttypetypmodcoll(Oid relid, AttrNumber attnum, * get_collation_name * Returns the name of a given pg_collation entry. * - * Returns a palloc'd copy of the string, or NULL if no such constraint. + * Returns a palloc'd copy of the string, or NULL if no such collation. * * NOTE: since collation name is not unique, be wary of code that uses this * for anything except preparing error messages. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [PATCH] Comment typo in get_collation_name() comment
From
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > Hi Hackers, > > The comment for get_collation_name() seems to have been copy-pasted from > get_constraint_name(), but missed one s/constraint/collation/. > > Patch attached. Bump? Do I need to add this patch to the next commitfest? I thought trivial comment typo patches like this generally got commited without such bureaucracy? - ilmari -- "I use RMS as a guide in the same way that a boat captain would use a lighthouse. It's good to know where it is, but you generally don't want to find yourself in the same spot." - Tollef Fog Heen
Dagfinn Ilmari Mannsåker wrote: > ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > > > Hi Hackers, > > > > The comment for get_collation_name() seems to have been copy-pasted from > > get_constraint_name(), but missed one s/constraint/collation/. > > > > Patch attached. > > Bump? Do I need to add this patch to the next commitfest? I thought > trivial comment typo patches like this generally got commited without > such bureaucracy? The problem is that pg-hackers is now too much traffic, so unregistered patches customarily fall through cracks. Recommendation is to register all patches to avoid that problem. I have pushed it now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: [PATCH] Comment typo in get_collation_name() comment
From
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > The problem is that pg-hackers is now too much traffic, so unregistered > patches customarily fall through cracks. Recommendation is to register > all patches to avoid that problem. I shall keep that in mind and register even trivial patches in future if they don't get picked up straight away. > I have pushed it now. Thanks! - ilmari -- "The surreality of the universe tends towards a maximum" -- Skud's Law "Never formulate a law or axiom that you're not prepared to live with the consequences of." -- Skud's Meta-Law