Thread: [HACKERS] Typos in src/backend/optimizer/README
Hi, This sentence in the section of Partition-wise joins in src/backend/optimizer/README should be fixed: "This technique of breaking down a join between partition tables into join between their partitions is called partition-wise join." (1) s/a join between partition tables/a join between partitioned tables/ (2) s/join between their partitions/joins between their partitions/ It might be okay to leave #2 as-is, but I'd like to propose to change that way to make the meaning clear. Attached is a patch for that. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote: > This sentence in the section of Partition-wise joins in > src/backend/optimizer/README should be fixed: "This technique of breaking > down a join between partition tables into join between their partitions is > called partition-wise join." > > (1) s/a join between partition tables/a join between partitioned tables/ > (2) s/join between their partitions/joins between their partitions/ > > It might be okay to leave #2 as-is, but I'd like to propose to change that > way to make the meaning clear. I think you are right. I have committed the patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On 2017/10/28 18:15, Robert Haas wrote: > On Fri, Oct 27, 2017 at 9:34 AM, Etsuro Fujita > <fujita.etsuro@lab.ntt.co.jp> wrote: >> This sentence in the section of Partition-wise joins in >> src/backend/optimizer/README should be fixed: "This technique of breaking >> down a join between partition tables into join between their partitions is >> called partition-wise join." >> >> (1) s/a join between partition tables/a join between partitioned tables/ >> (2) s/join between their partitions/joins between their partitions/ >> >> It might be okay to leave #2 as-is, but I'd like to propose to change that >> way to make the meaning clear. > > I think you are right. I have committed the patch. Thank you. Best regards, Etsuro Fujita -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers