Thread: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.
[COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.
From
Andres Freund
Date:
Rewrite strnlen replacement implementation from 8a241792f96. The previous placement of the fallback implementation in libpgcommon was problematic, because libpqport functions need strnlen functionality. Move replacement into libpgport. Provide strnlen() under its posix name, instead of pg_strnlen(). Fix stupid configure bug, executing the test only when compiled with threading support. Author: Andres Freund Discussion: https://postgr.es/m/E1e1gR2-0005fB-SI@gemulon.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/fffd651e83ccbd6191a76be6ec7c6b1b27888fde Modified Files -------------- configure | 25 ++++++++++++++++++++++++- configure.in | 6 +++--- src/backend/utils/mmgr/mcxt.c | 3 +-- src/common/string.c | 20 -------------------- src/include/common/string.h | 15 --------------- src/include/pg_config.h.in | 4 ++++ src/include/pg_config.h.win32 | 10 +++++++--- src/include/port.h | 4 ++++ src/port/snprintf.c | 4 +--- src/port/strnlen.c | 33 +++++++++++++++++++++++++++++++++ 10 files changed, 77 insertions(+), 47 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.
From
Tom Lane
Date:
Andres Freund <andres@anarazel.de> writes:
> Rewrite strnlen replacement implementation from 8a241792f96.
Hm, did you hand-edit the configure script and then forget to undo it?
Cause what was committed was not right.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Rewrite strnlen replacement implementationfrom 8a241792f96.
From
Andres Freund
Date:
On 2017-10-10 19:15:13 -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: > > Rewrite strnlen replacement implementation from 8a241792f96. > > Hm, did you hand-edit the configure script and then forget to undo it? > Cause what was committed was not right. Yea, that was me testing the fallback :(. I think I need holidays. -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers