Thread: [HACKERS] Re: [COMMITTERS] pgsql: Allow multiple tables to be specified in oneVACUUM or ANALYZE c
[HACKERS] Re: [COMMITTERS] pgsql: Allow multiple tables to be specified in oneVACUUM or ANALYZE c
From
Michael Paquier
Date:
On Wed, Oct 4, 2017 at 7:53 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Allow multiple tables to be specified in one VACUUM or ANALYZE command. > > Not much to say about this; does what it says on the tin. > > However, formerly, if there was a column list then the ANALYZE action was > implied; now it must be specified, or you get an error. This is because > it would otherwise be a bit unclear what the user meant if some tables > have column lists and some don't. > > Nathan Bossart, reviewed by Michael Paquier and Masahiko Sawada, with some > editorialization by me Tom, it seems to me that in the portions you have editorialized, you have forgotten to update two comments still mentioning get_rel_oids() in vacuum.c and analyze.c. Those should now refer to expand_vacuum_rel() instead. Please see the attached. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
Re: [HACKERS] [COMMITTERS] pgsql: Allow multiple tables to be specified in one VACUUM or ANALYZE c
From
Tom Lane
Date:
Michael Paquier <michael.paquier@gmail.com> writes: > Tom, it seems to me that in the portions you have editorialized, you > have forgotten to update two comments still mentioning get_rel_oids() > in vacuum.c and analyze.c. Those should now refer to > expand_vacuum_rel() instead. Please see the attached. Oh, good point. I don't think that just s/get_rel_oids/expand_vacuum_rel/ will do though, as it leaves out the interaction with get_all_vacuum_rels. I decided that the point was of merely historical interest anyway, and just removed the reference to the other routine. The partitioned-table patches seem to have been a bit sloppy with maintaining these comments too, so I ended up doing more than that... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers