Thread: [HACKERS] list of credits for release notes
At the PGCon Developer Meeting it was agreed[0] to add a list of credits to the release notes, including everyone who was mentioned in a commit message. I have now completed that list. Attached is the proposed documentation commit as well as the raw list. Thoughts on the heading? I have considered "Credits", "Acknowledgements", "Thanks", but the first seemed better than the other ones. This was a manual process, so mistakes could have been made. I have gently edited variant spellings and obvious typos. For the following mentions I could not identify a name: mthrockmorton@hme.com Tels Zertrin <postgres_wiki@zertrin.org> zam6ak@gmail.com bug #14654 reported by James C. Jov in bug #14749 yxq <yxq@o2.pl> I respect that some people don't want their name on record, but then they don't go into the release credits either, I think. The considered commits have been git log REL9_6_STABLE..REL_10_STABLE currently up to 9ebc7781444fd15d56ed16e5312a954483e85cd9. I have also cross-checked the list against all PG10 commit fests, the committers list, and the contributors list on the web site. (That doesn't mean I added all those, but checked for obvious omissions against those.) The list is sorted using COLLATE "en-x-icu". Any thoughts? [0]: https://wiki.postgresql.org/wiki/PgCon_2017_Developer_Meeting#Release_notes_scope.2C_and_giving_credit -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
> On 27 Sep 2017, at 19:47, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > > At the PGCon Developer Meeting it was agreed[0] to add a list of credits > to the release notes, including everyone who was mentioned in a commit > message. I have now completed that list. Wow, it’s bigger than I expected. Thanks for compiling it. > > Attached is the proposed documentation commit as well as the raw list. At the very least my name is missing (I contributed the monitoring roles patch and pg_ls_log/waldir. I have no idea if othersare. > > Thoughts on the heading? I have considered "Credits", > "Acknowledgements", "Thanks", but the first seemed better than the other > ones I prefer Acknowledgments. > > This was a manual process, so mistakes could have been made. I have > gently edited variant spellings and obvious typos. > > > For the following mentions I could not identify a name: > > mthrockmorton@hme.com > Tels > Zertrin <postgres_wiki@zertrin.org> > zam6ak@gmail.com > bug #14654 reported by James C. > Jov in bug #14749 > yxq <yxq@o2.pl> > > I respect that some people don't want their name on record, but then > they don't go into the release credits either, I think. > > The considered commits have been > > git log REL9_6_STABLE..REL_10_STABLE > > currently up to 9ebc7781444fd15d56ed16e5312a954483e85cd9. > > I have also cross-checked the list against all PG10 commit fests, the > committers list, and the contributors list on the web site. (That > doesn't mean I added all those, but checked for obvious omissions > against those.) > > The list is sorted using COLLATE "en-x-icu". > > > Any thoughts? > > > [0]: > https://wiki.postgresql.org/wiki/PgCon_2017_Developer_Meeting#Release_notes_scope.2C_and_giving_credit > > -- > Peter Eisentraut http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services > <0001-Add-list-of-credits-to-release-notes.patch> > <credits.txt> > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Hi, On 2017-09-27 14:47:45 -0400, Peter Eisentraut wrote: > At the PGCon Developer Meeting it was agreed[0] to add a list of credits > to the release notes, including everyone who was mentioned in a commit > message. I have now completed that list. Nice! > For the following mentions I could not identify a name: > > mthrockmorton@hme.com > Tels > Zertrin <postgres_wiki@zertrin.org> > zam6ak@gmail.com > bug #14654 reported by James C. > Jov in bug #14749 > yxq <yxq@o2.pl> > > I respect that some people don't want their name on record, but then > they don't go into the release credits either, I think. +1 > The list is sorted using COLLATE "en-x-icu". I think while it's fairly obvious, I'd still mention that the list is alphabetically ordered. Regards, Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: pgsql-hackers-owner@postgresql.org > [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Peter Eisentraut > At the PGCon Developer Meeting it was agreed[0] to add a list of credits > to the release notes, including everyone who was mentioned in a commit > message. I have now completed that list. Thank you for your hard work. "Daisuke Higuchi" and "Higuchi Daisuke" are the same person (my colleague). Please use theformer. Regards Takayuki Tsunakawa -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Sep 28, 2017 at 9:11 AM, Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com> wrote: > From: pgsql-hackers-owner@postgresql.org >> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Peter Eisentraut >> At the PGCon Developer Meeting it was agreed[0] to add a list of credits >> to the release notes, including everyone who was mentioned in a commit >> message. I have now completed that list. Nice! > Thank you for your hard work. "Daisuke Higuchi" and "Higuchi Daisuke" are the same person (my colleague). Please usethe former. Right. Looking at this list, the first name is followed by the family name, so there are inconsistencies with some Japanese names: - Fujii Masao should be Masao Fujii. - KaiGai Kohei should be Kohei Kaigai. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > Looking at this list, the first name is followed by the family name, > so there are inconsistencies with some Japanese names: > - Fujii Masao should be Masao Fujii. > - KaiGai Kohei should be Kohei Kaigai. But his emails say Fujii Masao, not Masao Fujii. KaiGai's case is a bit trickier, as his email name has changed over time. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On 9/29/17 11:35, Robert Haas wrote: > On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> Looking at this list, the first name is followed by the family name, >> so there are inconsistencies with some Japanese names: >> - Fujii Masao should be Masao Fujii. >> - KaiGai Kohei should be Kohei Kaigai. > > But his emails say Fujii Masao, not Masao Fujii. > > KaiGai's case is a bit trickier, as his email name has changed over time. Yes, I used the form that the person used in their emails. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On 9/27/17 14:55, Dave Page wrote: >> Attached is the proposed documentation commit as well as the raw list. > At the very least my name is missing (I contributed the monitoring roles patch and pg_ls_log/waldir. I have no idea ifothers are. > > >> Thoughts on the heading? I have considered "Credits", >> "Acknowledgements", "Thanks", but the first seemed better than the other >> ones > I prefer Acknowledgments. Committed with those changes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 29, 2017 at 12:00:05PM -0400, Peter Eisentraut wrote: > On 9/29/17 11:35, Robert Haas wrote: > > On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier > > <michael.paquier@gmail.com> wrote: > >> Looking at this list, the first name is followed by the family name, > >> so there are inconsistencies with some Japanese names: > >> - Fujii Masao should be Masao Fujii. > >> - KaiGai Kohei should be Kohei Kaigai. > > > > But his emails say Fujii Masao, not Masao Fujii. > > > > KaiGai's case is a bit trickier, as his email name has changed over time. > > Yes, I used the form that the person used in their emails. How should this be handled for the Postgres 11 release notes? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Bruce, * Bruce Momjian (bruce@momjian.us) wrote: > On Fri, Sep 29, 2017 at 12:00:05PM -0400, Peter Eisentraut wrote: > > On 9/29/17 11:35, Robert Haas wrote: > > > On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier > > > <michael.paquier@gmail.com> wrote: > > >> Looking at this list, the first name is followed by the family name, > > >> so there are inconsistencies with some Japanese names: > > >> - Fujii Masao should be Masao Fujii. > > >> - KaiGai Kohei should be Kohei Kaigai. > > > > > > But his emails say Fujii Masao, not Masao Fujii. > > > > > > KaiGai's case is a bit trickier, as his email name has changed over time. > > > > Yes, I used the form that the person used in their emails. > > How should this be handled for the Postgres 11 release notes? Ideally, we would let the individuals choose how to be recognized in release notes, and anywhere else we recognize them. We have the start of that in https://postgresql.org/account/profile but that isn't very easily tied to things in the commit history or elsewhere, yet. I'd suggest that we try to improve on that by: - Allowing anyone to include contributor information in their .Org account, even if they aren't listed on the Contributorspage. - Add in a field along the lines of "Name to be used publicly" and let them decide what they'd like, possibly even with theoption to not be publicly listed at all. - Add tracking of multiple email addresses into the .Org profile (somehow sync'd with the pglister system) - Start including contributor email addresses in commit messages along with names. I don't think we're that far off from this being possible to do in a more formal way that minimizes the risk of getting things incorrect, missing someone, or mis-attributing something. This all involves mostly work on the .Org system, which we do have some folks working on now but is also open source and it certainly wouldn't hurt to have more people involved, if there are others who are interested. The place to actually start the discussion of such changes would be -www though. Thanks! Stephen
> On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> Looking at this list, the first name is followed by the family name, >> so there are inconsistencies with some Japanese names: >> - Fujii Masao should be Masao Fujii. >> - KaiGai Kohei should be Kohei Kaigai. > > But his emails say Fujii Masao, not Masao Fujii. Michael is correct. Sometimes people choose family name first in the emails. However I am sure "Fujii" is the family name and "Masao" is the firstname. > KaiGai's case is a bit trickier, as his email name has changed over time. Michael is correct about Kaigai too. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Oct 2, 2017 at 02:12:50PM -0400, Stephen Frost wrote: > > How should this be handled for the Postgres 11 release notes? > > Ideally, we would let the individuals choose how to be recognized in > release notes, and anywhere else we recognize them. We have the start > of that in https://postgresql.org/account/profile but that isn't very > easily tied to things in the commit history or elsewhere, yet. I'd > suggest that we try to improve on that by: My smaller question is how will this list be generated in PG 11? From the commit log when the release notes are created, or some other method? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Oct 2, 2017 at 5:09 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> Michael is correct.
>
> Sometimes people choose family name first in the emails. However I am
> sure "Fujii" is the family name and "Masao" is the firstname.
But I don't think that directly answers the question of how he would
prefer to be credited. Since I am American, I prefer to be credited
using the style "${FIRSTNAME} ${LASTNAME}", but the preferences of
someone from another country might be the same or different. I don't
think we should presume that someone prefers something other than the
style in their email name unless they say so.
The question of what to do about pseudonyms is a tricky one - I'm not
really keen to have such things in the release notes in lieu of actual
names.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2017-10-03 6:09 GMT+09:00 Tatsuo Ishii <ishii@sraoss.co.jp>:
>> On Wed, Sep 27, 2017 at 8:29 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> Looking at this list, the first name is followed by the family name,
>>> so there are inconsistencies with some Japanese names:
>>> - Fujii Masao should be Masao Fujii.
>>> - KaiGai Kohei should be Kohei Kaigai.
>>
>> But his emails say Fujii Masao, not Masao Fujii.
>
> Michael is correct.
>
> Sometimes people choose family name first in the emails. However I am
> sure "Fujii" is the family name and "Masao" is the firstname.
>
>> KaiGai's case is a bit trickier, as his email name has changed over time.
>
> Michael is correct about Kaigai too.
>
I set up my personal e-mail account using ${FAMILYNAME} ${FIRSTNAME}
manner according to the eastern convention.
However, my last company enforced a centralized e-mail account policy,
so ${FIRSTNAME} ${LASTNAME} was shown when I post a message
from the jp.nec.com domain.
It is the reason why my email name has changed.
Thanks,
--
HeteroDB, Inc / The PG-Strom Project
KaiGai Kohei <kaigai@heterodb.com>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
> On Mon, Oct 2, 2017 at 5:09 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> Michael is correct.
>>
>> Sometimes people choose family name first in the emails. However I am
>> sure "Fujii" is the family name and "Masao" is the firstname.
>
> But I don't think that directly answers the question of how he would
> prefer to be credited.
Of course. It's different story.
> Since I am American, I prefer to be credited
> using the style "${FIRSTNAME} ${LASTNAME}", but the preferences of
> someone from another country might be the same or different. I don't
> think we should presume that someone prefers something other than the
> style in their email name unless they say so.
My concern is that the list seems implicitly assumes that each name
appears first name then last name. So people might misunderstand that
"Fujii" is the first name and "Masao" is the last name. I don't how he
actually feels about that, but if I were him, I would feel
uncomfortable. If the list explicitly stats that we do not guarantee
that the order of the last names and the first names are correct, then
that kind of misunderstanding could be avoided.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Oct 3, 2017 at 9:57 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> On Mon, Oct 2, 2017 at 5:09 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>>> Michael is correct.
>>>
>>> Sometimes people choose family name first in the emails. However I am
>>> sure "Fujii" is the family name and "Masao" is the firstname.
>>
>> But I don't think that directly answers the question of how he would
>> prefer to be credited.
>
> Of course. It's different story.
>
>> Since I am American, I prefer to be credited
>> using the style "${FIRSTNAME} ${LASTNAME}", but the preferences of
>> someone from another country might be the same or different. I don't
>> think we should presume that someone prefers something other than the
>> style in their email name unless they say so.
>
> My concern is that the list seems implicitly assumes that each name
> appears first name then last name. So people might misunderstand that
> "Fujii" is the first name and "Masao" is the last name. I don't how he
> actually feels about that, but if I were him, I would feel
> uncomfortable. If the list explicitly stats that we do not guarantee
> that the order of the last names and the first names are correct, then
> that kind of misunderstanding could be avoided.
Yeah, your concern might be right, but I prefer Fujii Masao,
i.e., family-name-first style, so I have used that name in my email
and past release notes so far.
Anyway, thanks for your kind consideration!
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Michael Paquier wrote: > Looking at this list, the first name is followed by the family name, > so there are inconsistencies with some Japanese names: > - Fujii Masao should be Masao Fujii. > - KaiGai Kohei should be Kohei Kaigai. We've already been here: https://www.postgresql.org/message-id/20150613231826.GY133018@postgresql.org -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
2017/09/28 3:47、Peter Eisentraut <peter.eisentraut@2ndquadrant.com> のメッセージ:
At the PGCon Developer Meeting it was agreed[0] to add a list of credits
to the release notes, including everyone who was mentioned in a commit
message. I have now completed that list.
Attached is the proposed documentation commit as well as the raw list.
Thanks!
Sorry but please change "Huong Dangminh"(my name) to "Dang Minh Huong".
---
Dang Minh Huong
Peter Eisentraut wrote: > At the PGCon Developer Meeting it was agreed[0] to add a list of credits > to the release notes, including everyone who was mentioned in a commit > message. I have now completed that list. > > Attached is the proposed documentation commit as well as the raw list. > The list is sorted using COLLATE "en-x-icu". It would be awesome if the list could be sorted by last name, as name lists traditionally are, but maybe that's too much to ask. Yours, Laurenz Albe -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Oct 4, 2017 at 8:51 AM, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
Peter Eisentraut wrote:
> At the PGCon Developer Meeting it was agreed[0] to add a list of credits
> to the release notes, including everyone who was mentioned in a commit
> message. I have now completed that list.
>
> Attached is the proposed documentation commit as well as the raw list.
> The list is sorted using COLLATE "en-x-icu".
It would be awesome if the list could be sorted by last name,
as name lists traditionally are, but maybe that's too much to ask.
Whether that's traditionally or not very much depends on which part of the world you are in, I believe. Let's try to avoid going down that rabbithole :)
On 10/2/17 18:34, Bruce Momjian wrote: > My smaller question is how will this list be generated in PG 11? From > the commit log when the release notes are created, or some other method? I don't think it should be done at the same time as the release notes. Specifically, we have recently put an emphasis on having the release notes ready for beta, and the natural flow of things should be that there are relatively few changes to the the substance of the release notes once beta gets rolling. On the other hand, I have found that a significant amount of new contributors appear in commit messages during beta, which also makes some sense. So making the contributor list fairly late and then not changing it much is more efficient. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On 10/3/17 12:31, Dang Minh Huong wrote: > Sorry but please change "Huong Dangminh"(my name) to "Dang Minh Huong". done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Nov 1, 2017 at 11:24:03PM -0400, Peter Eisentraut wrote: > On 10/2/17 18:34, Bruce Momjian wrote: > > My smaller question is how will this list be generated in PG 11? From > > the commit log when the release notes are created, or some other method? > > I don't think it should be done at the same time as the release notes. > > Specifically, we have recently put an emphasis on having the release > notes ready for beta, and the natural flow of things should be that > there are relatively few changes to the the substance of the release > notes once beta gets rolling. On the other hand, I have found that a > significant amount of new contributors appear in commit messages during > beta, which also makes some sense. So making the contributor list > fairly late and then not changing it much is more efficient. Sorry for the late reply. If you can create the contributors list easily post-release-notes creation, all the better for me. Thanks. :-) Creating the list during release notes creation would certainly be a separate step, so you are right that creating them later when the list is fully accurate is a good idea. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +