Thread: Re: [HACKERS] [COMMITTERS] pgsql: passwordcheck: Add test suite
On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote: > passwordcheck: Add test suite > > Also improve one error message. > > Reviewed-by: David Steele <david@pgmasters.net> Sorry for showing up late for this topic. +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf +REGRESS = passwordcheck +# disabled because these tests require setting shared_preload_libraries +NO_INSTALLCHECK = 1 You could have avoided all that by just issuing "load 'passwordcheck';" at the beginning of the test. And you gain support for installcheck this way. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote: >> passwordcheck: Add test suite >> >> Also improve one error message. >> >> Reviewed-by: David Steele <david@pgmasters.net> > > Sorry for showing up late for this topic. > +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf > +REGRESS = passwordcheck > +# disabled because these tests require setting shared_preload_libraries > +NO_INSTALLCHECK = 1 > You could have avoided all that by just issuing "load > 'passwordcheck';" at the beginning of the test. And you gain support > for installcheck this way. In short you just need the attached ;) -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
On 9/15/17 00:20, Michael Paquier wrote: > On Fri, Sep 15, 2017 at 12:02 PM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> On Fri, Sep 15, 2017 at 11:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote: >>> passwordcheck: Add test suite >>> >>> Also improve one error message. >>> >>> Reviewed-by: David Steele <david@pgmasters.net> >> >> Sorry for showing up late for this topic. >> +REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf >> +REGRESS = passwordcheck >> +# disabled because these tests require setting shared_preload_libraries >> +NO_INSTALLCHECK = 1 >> You could have avoided all that by just issuing "load >> 'passwordcheck';" at the beginning of the test. And you gain support >> for installcheck this way. > > In short you just need the attached ;) committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers