Thread: Array representation and save array data from datagrid [RM2671][pgAdmin4]
Attachment
On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Adding Akshay...
Sure.
On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Harshal,
Can you please rebase the patch, it's not applied with the latest code.
On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
It works, sorry for the noise.
On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Hi Harshal
I have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.
On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Thanks, I'll look into it.
On Sep 14, 2017 5:31 PM, "Akshay Joshi" <akshay.joshi@enterprisedb.com> wrote:
Hi HarshalI have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Hi Harshal and Akshay,
I'm noticing that the screenshots you attached have fonts that look different (ex. no font weights for table headers). Is that a result of the font bundling and needs to be updated?
On Fri, Sep 15, 2017 at 12:18 AM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Thanks, I'll look into it.On Sep 14, 2017 5:31 PM, "Akshay Joshi" <akshay.joshi@enterprisedb.com> wrote:Hi HarshalI have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--------
Hi Akshay,
It's not issue; Try without quotes. As char data type stores only one character so it's storing only leading quote (') and
truncating remaining characters (a').
Only exception is when you want to store empty string (char) use two quotes (either single or double)
they will translated before sending to server.
Apart from this I found that data types "char" and "char"[] (alias to character and character[] respectively)
were not taken into consideration in sqleditor.js. I have attached updated patch which fixes this issue.
--
Harshal Dhumal
Sr. Software Engineer
On Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi HarshalI have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment
Thanks patch applied.
On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Akshay,It's not issue; Try without quotes. As char data type stores only one character so it's storing only leading quote (') andtruncating remaining characters (a').Only exception is when you want to store empty string (char) use two quotes (either single or double)they will translated before sending to server.Apart from this I found that data types "char" and "char"[] (alias to character and character[] respectively)were not taken into consideration in sqleditor.js. I have attached updated patch which fixes this issue.--Harshal DhumalSr. Software EngineerOn Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Hi HarshalI have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Hi Harshal,
Could you please look at the latest issue reported by user on https://redmine.postgresql.org/issues/2258#change-8312
It looks like regression of RM#2671 changes.
--
Regards,
On Mon, Sep 18, 2017 at 12:07 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.On Fri, Sep 15, 2017 at 6:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Akshay,It's not issue; Try without quotes. As char data type stores only one character so it's storing only leading quote (') andtruncating remaining characters (a').Only exception is when you want to store empty string (char) use two quotes (either single or double)they will translated before sending to server.Apart from this I found that data types "char" and "char"[] (alias to character and character[] respectively)were not taken into consideration in sqleditor.js. I have attached updated patch which fixes this issue.--Harshal DhumalSr. Software EngineerOn Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Hi HarshalI have reviewed your patch it looks good to me. Only one issue I have found with char[], when I store {'a','b','c'} it gets stored and when I refreshed it shows {',','}. Please look into this issue.On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: It works, sorry for the noise.On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Harshal,Can you please rebase the patch, it's not applied with the latest code.On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: On Tue, Sep 12, 2017 at 2:34 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Akshay...Sure.On Tue, Sep 12, 2017 at 10:04 AM, Dave Page <dpage@pgadmin.org> wrote:Akshay, can you review/commit this please?--On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached patch to represent array data in datagrid with curly braces andalso allow user to save array with values like <null>, <empty string>, '""' and "''"--Harshal DhumalSr. Software EngineerDave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Akshay JoshiPrincipal Software EngineerPhone: +91 20-3058-9517
Mobile: +91 976-788-8246