Thread: [COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

From
Tom Lane
Date:
Fix more portability issues in new pgbench TAP tests.

* Remove no-such-user test case, output isn't stable, and we really
don't need to be testing such cases here anyway.

* Fix the process exit code test logic to match PostgresNode::psql
(but I didn't bother with looking at the "core" flag).

* Give up on inf/nan tests.

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/77d63b7eafd44469c2766c1f29b75533981e4911

Modified Files
--------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 20 +++-----------------
src/test/perl/TestLib.pm                     | 14 ++++++++------
2 files changed, 11 insertions(+), 23 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Fix more portability issues in new pgbenchTAP tests.

From
Fabien COELHO
Date:
> Fix more portability issues in new pgbench TAP tests.

Sorry for all these issues unforeseen issues. Thanks to the farm!

> * Remove no-such-user test case, output isn't stable, and we really
> don't need to be testing such cases here anyway.

Ok.

> * Fix the process exit code test logic to match PostgresNode::psql
> (but I didn't bother with looking at the "core" flag).

Ok. At least it is consistent.

> * Give up on inf/nan tests.

Too bad, I liked them!

Thanks for the fixes.

-- 
Fabien.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers