Thread: pgAdmin4: Cleanup in role dependency test cases

pgAdmin4: Cleanup in role dependency test cases

From
Navnath Gadakh
Date:
Hi Dave,

Role dependency test cases are failing due to database error 'ERROR: cache lookup failed for database XXXXXX'. Test-suite throwing error on "DROP ROLE <role_name>".
This is intermittent issue I was executing test cases on all servers (pg9.2-10 and ppas9.2-10)

Somehow the 'DROP database' didn't drop the shared dependencies correctly in role dependency test cases. 
PostgreSQL still thinks that Role owns 1 table in the database which is dropped now .Due to that role was not able to drop. 
This could be a bug in PG. Anyway, since the database is dropped, it is safe to manually remove the user as it is not of any use more.


Please find the patch.

Thanks.

--
Regards,
Navnath Gadakh

EnterpriseDB Corporation
The Enterprise PostgreSQL Company


Attachment

Re: pgAdmin4: Cleanup in role dependency test cases

From
Dave Page
Date:
Hi

On Wed, Aug 30, 2017 at 6:34 AM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,

Role dependency test cases are failing due to database error 'ERROR: cache lookup failed for database XXXXXX'. Test-suite throwing error on "DROP ROLE <role_name>".
This is intermittent issue I was executing test cases on all servers (pg9.2-10 and ppas9.2-10)

Somehow the 'DROP database' didn't drop the shared dependencies correctly in role dependency test cases. 
PostgreSQL still thinks that Role owns 1 table in the database which is dropped now .Due to that role was not able to drop. 
This could be a bug in PG. Anyway, since the database is dropped, it is safe to manually remove the user as it is not of any use more.

It's never safe to remove a user like that - plus the user would need rolcatupdate privs for it to even work (which a superuser doesn't have by default).

Have you run the problem past the DB Server team?

Another point to note is that support for 9.2 will end very soon, so it might not be worth worrying about.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company