Thread: [pgAdmin4][Patch]: Use the correct resultset type for Type module
Hi,
PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.
There is no RM just a minor enhancement.
--
Regards,
Attachment
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Harshal,Hi,PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.There is no RM just a minor enhancement.
Please review this one.
--Regards,
On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Harshal,Hi,PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.There is no RM just a minor enhancement.Please review this one.
I tested this and it's working fine.
--Regards,
Thanks patch applied.
On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Harshal,Hi,PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.There is no RM just a minor enhancement.Please review this one.I tested this and it's working fine.--Regards,
Akshay Joshi
Principal Software Engineer
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246