Thread: [pgAdmin4][Patch]: Use the correct resultset type for Type module

[pgAdmin4][Patch]: Use the correct resultset type for Type module

From
Murtuza Zabuawala
Date:
Hi,

PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.
There is no RM just a minor enhancement.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

From
Ashesh Vashi
Date:
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.
There is no RM just a minor enhancement.
Harshal,

Please review this one.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

From
Harshal Dhumal
Date:

On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.
There is no RM just a minor enhancement.
Harshal,

Please review this one.
I tested this and it's working fine.

 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

From
Akshay Joshi
Date:
Thanks patch applied.

On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly.
There is no RM just a minor enhancement.
Harshal,

Please review this one.
I tested this and it's working fine.

 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246