Thread: [JDBC] [pgjdbc/pgjdbc] 8287e7: test: assume integer datetimes for timestamptests...
[JDBC] [pgjdbc/pgjdbc] 8287e7: test: assume integer datetimes for timestamptests...
From
Michael Glaesemann
Date:
Branch: refs/heads/master Home: https://github.com/pgjdbc/pgjdbc Commit: 8287e7f92f890a41f8d2b51980157a92e1cd57e8 https://github.com/pgjdbc/pgjdbc/commit/8287e7f92f890a41f8d2b51980157a92e1cd57e8 Author: Michael Glaesemann <grzm@seespotcode.net> Date: 2017-07-24 (Mon, 24 Jul 2017) Changed paths: M pgjdbc/src/test/java/org/postgresql/test/TestUtil.java M pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGTimeTest.java M pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGTimestampTest.java M pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimestampTest.java M pgjdbc/src/test/java/org/postgresql/test/jdbc42/GetObject310Test.java M pgjdbc/src/test/java/org/postgresql/test/jdbc42/SetObject310Test.java Log Message: ----------- test: assume integer datetimes for timestamp tests (#873) Float timestamp equality comparisons like comparisons with any float are problematic if they don't take into account their imprecise nature. Some timestamp tests produce false negative failures for servers compiled with float timestamps. Use JUnit assumptions to skip these tests if the server doesn't have integer datetimes. This addresses https://github.com/pgjdbc/pgjdbc/issues/12 in part in that it omits (most of) the failing tests, though it leaves these timestamp behaviors untested under float timestamps, which was the default prior to PostgreSQL 8.4.