Thread: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests
[RM2544][pgAdmin4] Add SSL database connection support in Regression tests
From
Murtuza Zabuawala
Date:
Hi,
PFA patch to add SSL support for database connection.
RM#2170
Included test to check if current connection is using SSL or not.
--
Regards,
Attachment
Hi
--
On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to add SSL support for database connection.RM#2170Included test to check if current connection is using SSL or not
I think the SSL test needs a little work. Instead of:
Test for SSL connection check ... Traceback (most recent call last):
File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tests/test_check_ssl_connection.py", line 42, in runTest
self.server['sslmode']
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 408, in skipTest
raise SkipTest(reason)
SkipTest: Cannot run SSL connection check test with 'prefer' sslmode
skipped "Cannot run SSL connection check test with 'prefer' sslmode"
I would expect to see:
runTest (pgadmin.browser.server_groups.servers.tests.test_check_ssl_connection.TestSSLConnectionCheck)
Test SSL Connection ... skipped "Cannot run SSL connection check test with 'prefer' sslmode"
Thanks.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [RM2544][pgAdmin4] Add SSL database connection support inRegression tests
From
Murtuza Zabuawala
Date:
Hi Dave,
Please find updated patch for the same.
On Mon, Jul 17, 2017 at 8:59 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add SSL support for database connection.RM#2170Included test to check if current connection is using SSL or notI think the SSL test needs a little work. Instead of:Test for SSL connection check ... Traceback (most recent call last):File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_ groups/servers/tests/test_ check_ssl_connection.py", line 42, in runTest self.server['sslmode']File "/System/Library/Frameworks/Python.framework/Versions/2.7/ lib/python2.7/unittest/case. py", line 408, in skipTest raise SkipTest(reason)SkipTest: Cannot run SSL connection check test with 'prefer' sslmodeskipped "Cannot run SSL connection check test with 'prefer' sslmode"I would expect to see:runTest (pgadmin.browser.server_
groups.servers.tests.test_ check_ssl_connection. TestSSLConnectionCheck)
Test SSL Connection ... skipped "Cannot run SSL connection check test with 'prefer' sslmode"Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, applied.
On Tue, Jul 18, 2017 at 6:30 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,Please find updated patch for the same.On Mon, Jul 17, 2017 at 8:59 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to add SSL support for database connection.RM#2170Included test to check if current connection is using SSL or notI think the SSL test needs a little work. Instead of:Test for SSL connection check ... Traceback (most recent call last):File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups /servers/tests/test_check_ssl_ connection.py", line 42, in runTest self.server['sslmode']File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/unittest/case.py", line 408, in skipTest raise SkipTest(reason)SkipTest: Cannot run SSL connection check test with 'prefer' sslmodeskipped "Cannot run SSL connection check test with 'prefer' sslmode"I would expect to see:runTest (pgadmin.browser.server_groups
.servers.tests.test_check_ssl_ connection.TestSSLConnectionCh eck)
Test SSL Connection ... skipped "Cannot run SSL connection check test with 'prefer' sslmode"Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company