Postgres Pro
Downloads
Home   >   mailing lists

Thread: [HACKERS] Minor style cleanup in tab-complete.c

[HACKERS] Minor style cleanup in tab-complete.c

From
Thomas Munro
Date:
Hi,

From the triviality department: I noticed some branches in
tab-complete.c's gargantuan if statement, mostly brand new, that break
from the established brace style.  Should we fix that like this?

-- 
Thomas Munro
http://www.enterprisedb.com

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

Re: [HACKERS] Minor style cleanup in tab-complete.c

From
Michael Paquier
Date:
On Wed, Jul 12, 2017 at 11:19 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> From the triviality department: I noticed some branches in
> tab-complete.c's gargantuan if statement, mostly brand new, that break
> from the established brace style.  Should we fix that like this?

For consistency I think it does.
-- 
Michael

Re: [HACKERS] Minor style cleanup in tab-complete.c

From
Heikki Linnakangas
Date:
On 07/12/2017 07:39 AM, Michael Paquier wrote:
> On Wed, Jul 12, 2017 at 11:19 AM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> From the triviality department: I noticed some branches in
>> tab-complete.c's gargantuan if statement, mostly brand new, that break
>> from the established brace style.  Should we fix that like this?
>
> For consistency I think it does.

Agreed. Committed, thanks.

- Heikki