Thread: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.
Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. Per buildfarm. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1ae8536545b7ea486dbe15247e6dd817ee211297 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 4 ++++ src/tools/msvc/Mkvcbuild.pm | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
Re: [COMMITTERS] pgsql: Ooops, WIN32 code in pg_ctl.c still needsPQExpBuffer.
From
Andrew Dunstan
Date:
On 06/28/2017 06:00 PM, Tom Lane wrote: > Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer. > > Per buildfarm. > Looks to me like we need to put back the Makefile line for WIN32 for pg_ctl, too. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 06/28/2017 06:00 PM, Tom Lane wrote:
>> Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.
> Looks to me like we need to put back the Makefile line for WIN32 for
> pg_ctl, too.
Oh, yuck. Forgot about mingw builds. Will fix.
regards, tom lane