Thread: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid isextremely slow and fails with large datasets
Attachment
Hi Khushboo,
I applied your patch and tried to copy result from grid but got below exception.
Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).
--
Harshal Dhumal
Sr. Software Engineer
On Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo
Hi
--
On Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).
Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.
--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi,
I haven't come across this error while development as I tested the patch with Javascript debugger on.
When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.
I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.
So, if anyone has any clue please let me know as I am still trying.
Thanks,
Khushboo
On Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Yes, that's weird issue, copy command works fine with debugger on and fails without debugger.
I used below code to check the status of copy command.
try { var status = document.execCommand('copy'); console.log('Copying text command was ' + (status ? 'successful' : 'unsuccessful'));
} catch (err) { alert('Oops, unable to copy to clipboard'); }
--
Regards,
On Thu, Jun 29, 2017 at 6:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi
--
So I tried this again on my main machine, but this time I see:
(pgadmin4)piranha:web dpage$ yarn run bundle
yarn run v0.24.6
$ yarn run linter && yarn run webpacker
yarn run v0.24.6
$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js
yarn run v0.24.6
$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/query_history.jsx pgadmin/static/jsx/history/query_history_detail.jsx pgadmin/static/jsx/history/query_history_entry.jsx pgadmin/static/js/selection/active_cell_capture.js pgadmin/static/js/selection/clipboard.js pgadmin/static/js/selection/column_selector.js pgadmin/static/js/selection/copy_data.js pgadmin/static/js/selection/grid_selector.js pgadmin/static/js/selection/range_boundary_navigator.js pgadmin/static/js/selection/range_selection_helper.js pgadmin/static/js/selection/row_selector.js pgadmin/static/js/selection/set_staged_rows.js pgadmin/static/js/selection/xcell_selection_model.js regression/javascript/history/query_history_spec.jsx regression/javascript/browser/menu_spec.js regression/javascript/history/history_collection_spec.js regression/javascript/selection/active_cell_capture_spec.js regression/javascript/selection/column_selector_spec.js regression/javascript/selection/copy_data_spec.js regression/javascript/selection/grid_selector_spec.js regression/javascript/selection/range_boundary_navigator_spec.js regression/javascript/selection/range_selection_helper_spec.js regression/javascript/selection/row_selector_spec.js regression/javascript/selection/set_staged_rows_spec.js regression/javascript/selection/xcell_selection_model_spec.js regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js
/Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/clipboard.js
49:7 error '$' is not defined no-undef
✖ 1 problem (1 error, 0 warnings)
On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.
--
Harshal Dhumal
Sr. Software Engineer
On Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:
HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/ query_history.jsx pgadmin/static/jsx/history/ query_history_detail.jsx pgadmin/static/jsx/history/ query_history_entry.jsx pgadmin/static/js/selection/ active_cell_capture.js pgadmin/static/js/selection/ clipboard.js pgadmin/static/js/selection/ column_selector.js pgadmin/static/js/selection/ copy_data.js pgadmin/static/js/selection/ grid_selector.js pgadmin/static/js/selection/ range_boundary_navigator.js pgadmin/static/js/selection/ range_selection_helper.js pgadmin/static/js/selection/ row_selector.js pgadmin/static/js/selection/ set_staged_rows.js pgadmin/static/js/selection/ xcell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/ selection/active_cell_capture_ spec.js regression/javascript/ selection/column_selector_ spec.js regression/javascript/ selection/copy_data_spec.js regression/javascript/ selection/grid_selector_spec. js regression/javascript/ selection/range_boundary_ navigator_spec.js regression/javascript/ selection/range_selection_ helper_spec.js regression/javascript/ selection/row_selector_spec.js regression/javascript/ selection/set_staged_rows_ spec.js regression/javascript/ selection/xcell_selection_ model_spec.js regression/javascript/ slickgrid/cell_selector_spec. js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/ clipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi,
--
Harshal Dhumal
Sr. Software Engineer
On Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_ spec.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec. js regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Haha - already fixed that in my tree. Just got some feature test failures to investigate...
On Fri, Jun 30, 2017 at 2:04 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Please find attached updated patch. In this I have fixed js linter related issues.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Please find attached updated patch. In this I have fixed js linter related issues.
Harshal, if we are settings clipboard data directly then do we need textarea control?
--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Regards,
On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?
@Khushboo, We need it because we can only trigger copy/cut event on input/textarea element.
--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Harshal,Clipboard API won't work with IE11 & Edge browser Link
Is there any alternative?
--Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 3:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Harshal,Clipboard API won't work with IE11 & Edge browser LinkIs there any alternative?
Apparently so. See https://github.com/ProseMirror/prosemirror/issues/325
--Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 8:19 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jun 30, 2017 at 3:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Harshal,Clipboard API won't work with IE11 & Edge browser LinkIs there any alternative?Apparently so. See https://github.com/ProseMirror/prosemirror/ issues/325
It is a good solution for all modern browser but we need some kind of fallback for IE and also for Edge (until Edge have that API developed and integrated), We also need to check if it is supported by ActiveQt.
--Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Jun 30, 2017 at 8:19 PM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Jun 30, 2017 at 3:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Harshal,Clipboard API won't work with IE11 & Edge browser LinkIs there any alternative?Apparently so. See https://github.com/ProseMirror/prosemirror/ issues/325 It is a good solution for all modern browser but we need some kind of fallback for IE and also for Edge (until Edge have that API developed and integrated), We also need to check if it is supported by ActiveQt.
ActiveQT isn't a browser. It's an ActiveX wrapper for Qt that we're using to embed the IWebBrowser2 control - which is the IE JS/rendering engine (e.g., the bit of IE where web pages are displayed).
--Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Please find attached updated patch. Now copy to clipboard with large data works on IE 11 and Edge browsers as well.
--
Harshal Dhumal
Sr. Software Engineer
On Fri, Jun 30, 2017 at 8:19 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Jun 30, 2017 at 3:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Harshal,Clipboard API won't work with IE11 & Edge browser LinkIs there any alternative?Apparently so. See https://github.com/ProseMirror/prosemirror/ issues/325 --Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, applied.
On Fri, Jun 30, 2017 at 3:33 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Dave,Please find attached updated patch. Now copy to clipboard with large data works on IE 11 and Edge browsers as well.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 8:19 PM, Dave Page <dpage@pgadmin.org> wrote:On Fri, Jun 30, 2017 at 3:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 7:00 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Harshal,Clipboard API won't work with IE11 & Edge browser LinkIs there any alternative?Apparently so. See https://github.com/ProseMirror/prosemirror/issues/325 --Regards,On Fri, Jun 30, 2017 at 6:44 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Fri, Jun 30, 2017 at 6:34 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi,Please find attached updated patch. In this I have fixed js linter related issues.Harshal, if we are settings clipboard data directly then do we need textarea control?--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 4:29 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Dave,Please find attached patch to fix copy large data to clipboard and improve copy/paste operation.--Harshal DhumalSr. Software EngineerOn Fri, Jun 30, 2017 at 2:33 PM, Dave Page <dpage@pgadmin.org> wrote:HiSo I tried this again on my main machine, but this time I see:(pgadmin4)piranha:web dpage$ yarn run bundleyarn run v0.24.6$ yarn run linter && yarn run webpackeryarn run v0.24.6$ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx regression/javascript/**/*.js *.js yarn run v0.24.6$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" pgadmin/static/jsx/history/que ry_history.jsx pgadmin/static/jsx/history/que ry_history_detail.jsx pgadmin/static/jsx/history/que ry_history_entry.jsx pgadmin/static/js/selection/ac tive_cell_capture.js pgadmin/static/js/selection/cl ipboard.js pgadmin/static/js/selection/co lumn_selector.js pgadmin/static/js/selection/co py_data.js pgadmin/static/js/selection/gr id_selector.js pgadmin/static/js/selection/ra nge_boundary_navigator.js pgadmin/static/js/selection/ra nge_selection_helper.js pgadmin/static/js/selection/ro w_selector.js pgadmin/static/js/selection/se t_staged_rows.js pgadmin/static/js/selection/xc ell_selection_model.js regression/javascript/history/ query_history_spec.jsx regression/javascript/browser/ menu_spec.js regression/javascript/history/ history_collection_spec.js regression/javascript/selectio n/active_cell_capture_spec.js regression/javascript/selectio n/column_selector_spec.js regression/javascript/selectio n/copy_data_spec.js regression/javascript/selectio n/grid_selector_spec.js regression/javascript/selectio n/range_boundary_navigator_spe c.js regression/javascript/selectio n/range_selection_helper_spec. js regression/javascript/selectio n/row_selector_spec.js regression/javascript/selectio n/set_staged_rows_spec.js regression/javascript/selectio n/xcell_selection_model_spec.j s regression/javascript/slickgri d/cell_selector_spec.js karma.conf.js webpack.config.js webpack.test.config.js /Users/dpage/git/pgadmin4/web/pgadmin/static/js/selection/cl ipboard.js 49:7 error '$' is not defined no-undef✖ 1 problem (1 error, 0 warnings)On Thu, Jun 29, 2017 at 1:40 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,I haven't come across this error while development as I tested the patch with Javascript debugger on.When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.So, if anyone has any clue please let me know as I am still trying.Thanks,KhushbooOn Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote: Hi Khushboo,I applied your patch and tried to copy result from grid but got below exception.Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.--Harshal DhumalSr. Software EngineerOn Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.Thanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company