Thread: [COMMITTERS] pgsql: Re-allow SRFs and window functions within sub-selects withinagg

Re-allow SRFs and window functions within sub-selects within aggregates.

check_agg_arguments_walker threw an error upon seeing a SRF or window
function, but that is too aggressive: if the function is within a
sub-select then it's perfectly fine.  I broke the SRF case in commit
0436f6bde by copying the logic for window functions ... but that was
broken too, and had been since commit eaccfded9.

Repair both cases in HEAD, and the window function case back to 9.3.
9.2 gets this right.

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3a7bd59c4496b5b9a7cec9ab6f1eb6b111a8b046

Modified Files
--------------
src/backend/parser/parse_agg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)