Thread: [pgAdmin4][Patch] To add preferences for brace matching and autobrace closing

Hi,

Please find patch to add preferences for brace matching and auto brace closing in SQL editor.

RM#2513

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks - patch applied with some minor tweaks to enable both options by default and adjust the help wording.

However, I realised right as I committed it, that you haven't updated the docs. Can you please update the screenshots affected and add the two new options to the docs please?

Thanks.

On Tue, Jun 27, 2017 at 9:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find patch to add preferences for brace matching and auto brace closing in SQL editor.

RM#2513

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Sure Dave, I'll do the needful.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jun 27, 2017 at 7:29 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks - patch applied with some minor tweaks to enable both options by default and adjust the help wording.

However, I realised right as I committed it, that you haven't updated the docs. Can you please update the screenshots affected and add the two new options to the docs please?

Thanks.

On Tue, Jun 27, 2017 at 9:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find patch to add preferences for brace matching and auto brace closing in SQL editor.

RM#2513

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

PFA patch for doc & screenshot.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jun 27, 2017 at 7:43 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Sure Dave, I'll do the needful.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jun 27, 2017 at 7:29 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks - patch applied with some minor tweaks to enable both options by default and adjust the help wording.

However, I realised right as I committed it, that you haven't updated the docs. Can you please update the screenshots affected and add the two new options to the docs please?

Thanks.

On Tue, Jun 27, 2017 at 9:21 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find patch to add preferences for brace matching and auto brace closing in SQL editor.

RM#2513

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company