Thread: [COMMITTERS] pgsql: Adjust pgindent script to use pg_bsd_indent 2.0.
Adjust pgindent script to use pg_bsd_indent 2.0. Update version-checking code and list of switches. Delete obsolete quasi-support for using GNU indent. Remove a lot of no-longer-needed workarounds for bugs of the old version, and improve comments for the hacks that remain. Update run_build() subroutine to fetch the pg_bsd_indent code from the newly established git repo for it. In passing, fix pgindent to not overwrite files that require no changes; this makes it a bit more friendly to run on a built tree. Adjust relevant documentation. Remove indent.bsd.patch; it's not relevant anymore (and was obsolete long ago anyway). Likewise remove pgcppindent, since we're no longer in the business of shipping C++ code. Piotr Stefaniak is responsible for most of the algorithmic changes to the pgindent script; I did the rest. Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8ff6d4ec7840b0af56f1207073f44b7f2afae96d Modified Files -------------- src/tools/pgindent/README | 21 ++- src/tools/pgindent/indent.bsd.patch | 288 ------------------------------------ src/tools/pgindent/pgcppindent | 29 ---- src/tools/pgindent/pgindent | 157 +++++--------------- src/tools/pgindent/pgindent.man | 5 +- 5 files changed, 52 insertions(+), 448 deletions(-)
On Wed, Jun 21, 2017 at 06:26:29PM +0000, Tom Lane wrote: > Adjust pgindent script to use pg_bsd_indent 2.0. > > Update version-checking code and list of switches. Delete obsolete > quasi-support for using GNU indent. Remove a lot of no-longer-needed > workarounds for bugs of the old version, and improve comments for > the hacks that remain. Update run_build() subroutine to fetch the Another hack of mine bits the dust. I see a few did remain. :-) -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +