Thread: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if clickon statistic tab for PG 10 server

Hi,

The issue is fixed now. Added a new "stats.sql" file with updated columns for the version 10.0_plus

PFA RM patch. 

Regards,
Atul


Attachment
Hi Atul,

On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
<atul.sharma@enterprisedb.com> wrote:
> Hi,
>
> The issue is fixed now. Added a new "stats.sql" file with updated columns
> for the version 10.0_plus
>
> PFA RM patch.

As PostgreSQL has moved to a 2 digit version number system instead of
3, I think the directory name should be 10_plus shouldn't it? Will
that work with the template search code? If not, can you please fix
that as well?

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Hi Dave,

I have made the template search code to work for 10_plus directory name. Please review the attached patch

Regards,
Atul.



On Thu, Jun 8, 2017 at 7:55 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi Atul,

On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
<atul.sharma@enterprisedb.com> wrote:
> Hi,
>
> The issue is fixed now. Added a new "stats.sql" file with updated columns
> for the version 10.0_plus
>
> PFA RM patch.

As PostgreSQL has moved to a 2 digit version number system instead of
3, I think the directory name should be 10_plus shouldn't it? Will
that work with the template search code? If not, can you please fix
that as well?

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment
Thanks Atul, patch applied.

On Fri, Jun 9, 2017 at 1:34 PM, Atul Sharma
<atul.sharma@enterprisedb.com> wrote:
> Hi Dave,
>
> I have made the template search code to work for 10_plus directory name.
> Please review the attached patch
>
> Regards,
> Atul.
>
>
>
> On Thu, Jun 8, 2017 at 7:55 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi Atul,
>>
>> On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
>> <atul.sharma@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > The issue is fixed now. Added a new "stats.sql" file with updated
>> > columns
>> > for the version 10.0_plus
>> >
>> > PFA RM patch.
>>
>> As PostgreSQL has moved to a 2 digit version number system instead of
>> 3, I think the directory name should be 10_plus shouldn't it? Will
>> that work with the template search code? If not, can you please fix
>> that as well?
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company