Thread: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

[pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

From
Murtuza Zabuawala
Date:
Hi,

PFA patch to fix the handling of  double precision[] type.
RM#1928

Steps to re-produce: Below given query fails to render result in Query tool,
SELECT ARRAY[1, 'nan', 3]::float[];

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment
Thanks, applied.

Can you update the data types feature test to cover this case please?

Thanks.

On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the handling of  double precision[] type.
> RM#1928
>
> Steps to re-produce: Below given query fails to render result in Query tool,
> SELECT ARRAY[1, 'nan', 3]::float[];
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of doubleprecision[] type

From
Murtuza Zabuawala
Date:
HI Dave,

Please find the patch for the added feature test for handling of RM#1928 datatype issue, other misc changes are for PEP-8.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 8, 2017 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

Can you update the data types feature test to cover this case please?

Thanks.

On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the handling of  double precision[] type.
> RM#1928
>
> Steps to re-produce: Below given query fails to render result in Query tool,
> SELECT ARRAY[1, 'nan', 3]::float[];
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment
Thanks, applied.

On Thu, Jun 15, 2017 at 11:47 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> HI Dave,
>
> Please find the patch for the added feature test for handling of RM#1928
> datatype issue, other misc changes are for PEP-8.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 8, 2017 at 7:21 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Thanks, applied.
>>
>> Can you update the data types feature test to cover this case please?
>>
>> Thanks.
>>
>> On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the handling of  double precision[] type.
>> > RM#1928
>> >
>> > Steps to re-produce: Below given query fails to render result in Query
>> > tool,
>> > SELECT ARRAY[1, 'nan', 3]::float[];
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company