Thread: [COMMITTERS] pgsql: Fix unsafe reference into relcache in constructed CommentStmt.
[COMMITTERS] pgsql: Fix unsafe reference into relcache in constructed CommentStmt.
From
Tom Lane
Date:
Fix unsafe reference into relcache in constructed CommentStmt. The CommentStmt made by RebuildConstraintComment() has to pstrdup the relation name, else it will contain a dangling pointer after that relcache entry is flushed. (I'm less sure that pstrdup'ing conname is necessary, but let's be safe.) Failure to do this leads to weird errors or crashes, as reported by Marko Elezovic. Bug introduced by commit e42375fc8, so back-patch to 9.5 as that was. Fix by David Rowley, regression test by Michael Paquier Discussion: https://postgr.es/m/DB6PR03MB30775D58E732D4EB0C13725B9AE00@DB6PR03MB3077.eurprd03.prod.outlook.com Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b35cce914cd3eef7d4a2471073c80f709d724e5a Modified Files -------------- src/backend/commands/tablecmds.c | 4 ++-- src/test/regress/expected/alter_table.out | 33 +++++++++++++++++++++++++++++++ src/test/regress/sql/alter_table.sql | 18 +++++++++++++++++ 3 files changed, 53 insertions(+), 2 deletions(-)