On 05/09/2017 09:37 PM, Michael Paquier wrote:
> On Wed, May 10, 2017 at 2:11 AM, Andrew Dunstan
> <andrew.dunstan@2ndquadrant.com> wrote:
>> (After extensive trial and error) Turns out it's not quite that, it's
>> the kill_kill stuff. I think for now we should just disable it on the
>> platform. That means not running tests 7 and 8 of the logical_decoding
>> tests and all of the crash_recovery test. test::More has nice
>> faciliti4es for skipping tests cleanly. See attached patch.
> +SKIP:
> +{
> + # some Windows Perls at least don't like IPC::Run's start/kill_kill regime.
> + skip "Test fails on Windows perl", 2 if $Config{osname} eq 'MSWin32';
> So this basically works with msys but not with MSWin32? Interesting...
On Msys we use the Msys DTK perl to run prove, and it executes the Msys
shell to run commands, with Msys signal emulation. The buildfarm client
goes to some trouble to arrange this. So it's very different.
>
> Does it make a different if you use for example coup_d_grace =>
> "QUIT"? Per the docs of IPC::Run SIGTERM is used for kills on Windows.
No idea. I'll try.
>
> +if ($Config{osname} eq 'MSWin32')
> +{
> + # some Windows Perls at least don't like IPC::Run's start/kill_kill regime.
> + plan skip_all => "Test fails on Windows perl";
> +}
> Indentation is weird here, with a mix of spaces and tabs.
I will indent it before I commit anything.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
