Thread: [COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworkerprocess
[COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworkerprocess
From
Tom Lane
Date:
Fix postmaster's handling of fork failure for a bgworker process. This corner case didn't behave nicely at all: the postmaster would (partially) update its state as though the process had started successfully, and be quite confused thereafter. Fix it to act like the worker had crashed, instead. In passing, refactor so that do_start_bgworker contains all the state-change logic for bgworker launch, rather than just some of it. Back-patch as far as 9.4. 9.3 contains similar logic, but it's just enough different that I don't feel comfortable applying the patch without more study; and the use of bgworkers in 9.3 was so small that it doesn't seem worth the extra work. transam/parallel.c is still entirely unprepared for the possibility of bgworker startup failure, but that seems like material for a separate patch. Discussion: https://postgr.es/m/4905.1492813727@sss.pgh.pa.us Branch ------ REL9_5_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dba1f310a564e8dc3496cd5ddec14ab6645ffd15 Modified Files -------------- src/backend/postmaster/postmaster.c | 108 +++++++++++++++++++++++++----------- 1 file changed, 77 insertions(+), 31 deletions(-)