Thread: [pgadmin-hackers] Patch for pgAdmin Installer web folder upgrade mode.
Hello Dave,
This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine.postgresql. org/issues/2187
Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.
Its working fine now.
Attached is the patch for same.
--
Thanks & Regards
Paresh More
Pune, India.
Attachment
Hi
--
On Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hello Dave,This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine. postgresql.org/issues/2187 Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.Its working fine now.Attached is the patch for same.
I get the following error when building:
Preparing for creation of windows installer...
1 file(s) copied.
Creating windows installer... using INNO tool
Error on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9:
Semicolon (';') expected.
Compile aborted.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hello Dave,
Can you please send me C:\Users\dpage\Documents\ pgadmin4\pkg\win32\installer. iss file
On Mon, Apr 10, 2017 at 2:30 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine.pos tgresql.org/issues/2187 Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.Its working fine now.Attached is the patch for same.I get the following error when building:Preparing for creation of windows installer...1 file(s) copied.Creating windows installer... using INNO toolError on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer. iss: Column 9: Semicolon (';') expected.Compile aborted.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attached.
On Mon, Apr 10, 2017 at 10:26 AM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hello Dave,Can you please send me C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss file --On Mon, Apr 10, 2017 at 2:30 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine.pos tgresql.org/issues/2187 Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.Its working fine now.Attached is the patch for same.I get the following error when building:Preparing for creation of windows installer...1 file(s) copied.Creating windows installer... using INNO toolError on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9: Semicolon (';') expected.Compile aborted.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL CompanyThanks & Regards
Paresh More
Pune, India.
Cell : +919922000564 | www.enterprisedb.com
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hello Dave
The error which mentioned comes only for unicode , for normal its working fine. I have made changes to installer.iss.in which works now fine for both the versions. (Normal and Unicode)
I have figured out the issue.
For Innosetup we have two downloads available.
1) Normal (innosetup-5.5.9.exe)
2) Unicode (innosetup-5.5.9-unicode.exe)
The error which mentioned comes only for unicode , for normal its working fine. I have made changes to installer.iss.in which works now fine for both the versions. (Normal and Unicode)
Attached is the patch.
end; <== Added ; and its working fine
until not FindNext(FindRec);
On Mon, Apr 10, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:
Attached.On Mon, Apr 10, 2017 at 10:26 AM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,Can you please send me C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss file --On Mon, Apr 10, 2017 at 2:30 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine.pos tgresql.org/issues/2187 Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.Its working fine now.Attached is the patch for same.I get the following error when building:Preparing for creation of windows installer...1 file(s) copied.Creating windows installer... using INNO toolError on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9: Semicolon (';') expected.Compile aborted.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL CompanyThanks & Regards
Paresh More
Pune, India.
Cell : +919922000564 | www.enterprisedb.com--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks - looks good, applied.
On Mon, Apr 10, 2017 at 10:53 AM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hello DaveI have figured out the issue.For Innosetup we have two downloads available.1) Normal (innosetup-5.5.9.exe)2) Unicode (innosetup-5.5.9-unicode.exe)
The error which mentioned comes only for unicode , for normal its working fine. I have made changes to installer.iss.in which works now fine for both the versions. (Normal and Unicode)Attached is the patch.end; <== Added ; and its working fineuntil not FindNext(FindRec);
On Mon, Apr 10, 2017 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:Attached.On Mon, Apr 10, 2017 at 10:26 AM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,Can you please send me C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss file --On Mon, Apr 10, 2017 at 2:30 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Sun, Apr 9, 2017 at 12:56 PM, Paresh More <paresh.more@enterprisedb.com> wrote:Hello Dave,This is regarding issue # 2187 ( Cleaning up web/* *except* config_local.py) through installer. https://redmine.pos tgresql.org/issues/2187 Now Inno installer would clean up web folder except config_local.py in upgrade mode and copy latest web folder in the installed location.Its working fine now.Attached is the patch for same.I get the following error when building:Preparing for creation of windows installer...1 file(s) copied.Creating windows installer... using INNO toolError on line 111 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 9: Semicolon (';') expected.Compile aborted.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL CompanyThanks & Regards
Paresh More
Pune, India.
Cell : +919922000564 | www.enterprisedb.com--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company