Thread: [COMMITTERS] pgsql: Avoid dangling pointer to relation name in RLS code path inDoCo
[COMMITTERS] pgsql: Avoid dangling pointer to relation name in RLS code path inDoCo
From
Tom Lane
Date:
Avoid dangling pointer to relation name in RLS code path in DoCopy(). With RLS active, "COPY tab TO ..." failed under -DRELCACHE_FORCE_RELEASE, and would sometimes fail without that, because it used the relation name directly from the relcache as part of the parsetree it's building. That becomes a potentially-dangling pointer as soon as the relcache entry is closed, a bit further down. Typical symptom if the relcache entry chanced to get cleared would be "relation does not exist" error with a garbage relation name, or possibly a core dump; but if you were really truly unlucky, the COPY might copy from the wrong table. Per report from Andrew Dunstan that regression tests fail with -DRELCACHE_FORCE_RELEASE. The core tests now pass for me (but have not tried "make check-world" yet). Discussion: https://postgr.es/m/7b52f900-0579-cda9-ae2e-de5da17090e6@2ndQuadrant.com Branch ------ REL9_6_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/943140d572adc94b957d123aa4c35ec88e40e869 Modified Files -------------- src/backend/commands/copy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)