Thread: [pgadmin-hackers] [PATCH][pgAdmin4] Move Bootstrap fonts to 'vendor/fonts' folder

Hi

On Tue, Feb 28, 2017 at 1:32 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to move bootstrap fonts to 'vender/fonts' folder as bootstrap.css
> looking for them as
>
>
> murtuza@vm:~/projects/pgadmin4$ grep -nr 'glyphicons'
> *web/pgadmin/static/vendor/bootstrap/bootstrap.css:270:  src:
> url('../fonts/glyphicons-halflings-regular.eot');
>
> web/pgadmin/static/vendor/bootstrap/bootstrap.css:271:  src:
> url('../fonts/glyphicons-halflings-regular.eot?#iefix')
> format('embedded-opentype'),
> url('../fonts/glyphicons-halflings-regular.woff2') format('woff2'),
> url('../fonts/glyphicons-halflings-regular.woff') format('woff'),
> url('../fonts/glyphicons-halflings-regular.ttf') format('truetype'),
> url('../fonts/glyphicons-halflings-regular.svg#glyphicons_halflingsregular')
> format('svg');

The patch just seems to remove the files altogether. I assume the
intent was to put them in web/pgadmin/static/vendor/fonts? I'm not
sure that's the best idea, as it would put them outside the bootstrap
directory. Perhaps we should update Bootstrap, and un-flatten it (i.e.
leave it in the distributed directory structure)?

> Also removed console.log from pgAgent node JS.

I've committed that bit, thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, applied (though, I removed npm.js again).

On Mon, Mar 13, 2017 at 12:19 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> Please find updated patch to move Bootstrap files in proper directory
> structure.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Feb 28, 2017 at 8:27 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Tue, Feb 28, 2017 at 1:32 PM, Murtuza Zabuawala
>> <murtuza.zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to move bootstrap fonts to 'vender/fonts' folder as
>> > bootstrap.css
>> > looking for them as
>> >
>> >
>> > murtuza@vm:~/projects/pgadmin4$ grep -nr 'glyphicons'
>> > *web/pgadmin/static/vendor/bootstrap/bootstrap.css:270:  src:
>> > url('../fonts/glyphicons-halflings-regular.eot');
>> >
>> > web/pgadmin/static/vendor/bootstrap/bootstrap.css:271:  src:
>> > url('../fonts/glyphicons-halflings-regular.eot?#iefix')
>> > format('embedded-opentype'),
>> > url('../fonts/glyphicons-halflings-regular.woff2') format('woff2'),
>> > url('../fonts/glyphicons-halflings-regular.woff') format('woff'),
>> > url('../fonts/glyphicons-halflings-regular.ttf') format('truetype'),
>> >
>> > url('../fonts/glyphicons-halflings-regular.svg#glyphicons_halflingsregular')
>> > format('svg');
>>
>> The patch just seems to remove the files altogether. I assume the
>> intent was to put them in web/pgadmin/static/vendor/fonts? I'm not
>> sure that's the best idea, as it would put them outside the bootstrap
>> directory. Perhaps we should update Bootstrap, and un-flatten it (i.e.
>> leave it in the distributed directory structure)?
>>
>> > Also removed console.log from pgAgent node JS.
>>
>> I've committed that bit, thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company