Thread: Re: [pgadmin-hackers] [Patch] Organize Vendorized Assets
Whoops, sorry, we messed up some CSS. We'll give you a new patch tomorrow.
Sarah & Tira
On Thu, Feb 23, 2017 at 5:58 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers,This patch creates a vendors directory that separates javascript/font/css dependencies that we have pulled in from external sources. This should make it easier to tell what code belongs to the pgadmin team and which files should not be edited. I think there is still more to be done in terms of organizing the javascript code, but this is a good start.Tira & Sarah
Here's our new patch.
If it looks a lot like the last one, that's because we actually just didn't clear our cache last night and were seeing in-flight css changes. End-of-day hallucinations :-p
Tira & Sarah
On Thu, Feb 23, 2017 at 6:05 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Whoops, sorry, we messed up some CSS. We'll give you a new patch tomorrow.Sarah & TiraOn Thu, Feb 23, 2017 at 5:58 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers,This patch creates a vendors directory that separates javascript/font/css dependencies that we have pulled in from external sources. This should make it easier to tell what code belongs to the pgadmin team and which files should not be edited. I think there is still more to be done in terms of organizing the javascript code, but this is a good start.Tira & Sarah
Attachment
Thanks, patch applied! On Fri, Feb 24, 2017 at 4:02 PM, Sarah McAlear <smcalear@pivotal.io> wrote: > Here's our new patch. > If it looks a lot like the last one, that's because we actually just didn't > clear our cache last night and were seeing in-flight css changes. End-of-day > hallucinations :-p > > Tira & Sarah > > On Thu, Feb 23, 2017 at 6:05 PM, Sarah McAlear <smcalear@pivotal.io> wrote: >> >> Whoops, sorry, we messed up some CSS. We'll give you a new patch tomorrow. >> >> Sarah & Tira >> >> On Thu, Feb 23, 2017 at 5:58 PM, Sarah McAlear <smcalear@pivotal.io> >> wrote: >>> >>> Hi Hackers, >>> >>> This patch creates a vendors directory that separates javascript/font/css >>> dependencies that we have pulled in from external sources. This should make >>> it easier to tell what code belongs to the pgadmin team and which files >>> should not be edited. I think there is still more to be done in terms of >>> organizing the javascript code, but this is a good start. >>> >>> Tira & Sarah >>> >> >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company